Skip to content

feat(connectors-sdk): add logging module and expose Logger (#6558)#7102

Open
Powlinett wants to merge 8 commits into
feat/7100-connectors-sdk-base-settings-fixesfrom
feat/6558-connectors-sdk-add-logger
Open

feat(connectors-sdk): add logging module and expose Logger (#6558)#7102
Powlinett wants to merge 8 commits into
feat/7100-connectors-sdk-base-settings-fixesfrom
feat/6558-connectors-sdk-add-logger

Conversation

@Powlinett

@Powlinett Powlinett commented Jul 24, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Create connectors_sdk.logging module with BaseLogger, Logger, and SdkLogger classes
  • Replace OpenCTIConnectorHelper logger usage with BaseLogger subclasses across SDK modules
  • Add structured logging to _SettingsLoader, BaseConnectorSettings, _BaseState, and connector classes
  • Remove WorkManager from public API (private module)
  • Declare python-dotenv dependency
  • Fix docstrings and typos

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

This PR is stacked on #7101 (BaseSettings fixes). It should be merged after that PR lands.
Supersedes #6559 (which combined both concerns in a single branch).

@Powlinett Powlinett added feature Type: new feature or capability (feat:). connectors-sdk Linked to connectors-sdk. labels Jul 24, 2026
@github-actions

This comment was marked as off-topic.

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                               Coverage Diff                                @@
##           feat/7100-connectors-sdk-base-settings-fixes    #7102      +/-   ##
================================================================================
+ Coverage                                         66.60%   66.68%   +0.07%     
================================================================================
  Files                                              1308     1310       +2     
  Lines                                             70265    70416     +151     
================================================================================
+ Hits                                              46803    46955     +152     
+ Misses                                            23462    23461       -1     
Files with missing lines Coverage Δ
connectors-sdk/connectors_sdk/__init__.py 100.00% <100.00%> (ø)
...rs_sdk/connectors/external_import/_work_manager.py 100.00% <100.00%> (ø)
.../connectors/external_import/base_data_processor.py 100.00% <100.00%> (ø)
...ctors/external_import/external_import_connector.py 100.00% <100.00%> (ø)
...nectors-sdk/connectors_sdk/logging/_base_logger.py 100.00% <100.00%> (ø)
connectors-sdk/connectors_sdk/logging/logger.py 100.00% <100.00%> (ø)
...onnectors-sdk/connectors_sdk/logging/sdk_logger.py 100.00% <100.00%> (ø)
...rs-sdk/connectors_sdk/settings/_settings_loader.py 100.00% <100.00%> (ø)
...ctors-sdk/connectors_sdk/settings/base_settings.py 100.00% <100.00%> (ø)
...onnectors-sdk/connectors_sdk/states/_base_state.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Powlinett
Powlinett force-pushed the feat/7100-connectors-sdk-base-settings-fixes branch from e96aa2c to 62c844f Compare July 24, 2026 15:08
@Powlinett
Powlinett force-pushed the feat/6558-connectors-sdk-add-logger branch from 7eb2ed7 to 7191c0a Compare July 24, 2026 15:08
@Powlinett
Powlinett force-pushed the feat/7100-connectors-sdk-base-settings-fixes branch from 62c844f to f6908d0 Compare July 24, 2026 15:16
@Powlinett
Powlinett force-pushed the feat/6558-connectors-sdk-add-logger branch from 7191c0a to 2cc9682 Compare July 24, 2026 15:17
@Powlinett Powlinett added filigran team Item from the Filigran team. do not merge Do not merge until this label is removed. and removed feature Type: new feature or capability (feat:). labels Jul 24, 2026
@Powlinett Powlinett linked an issue Jul 24, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connectors-sdk Linked to connectors-sdk. do not merge Do not merge until this label is removed. filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(connectors-sdk): add logging module

2 participants