patina_performance: Fix get_variable() call - #1775
Merged
makubacki merged 1 commit intoSep 14, 2026
Merged
Conversation
Contributor
✅ QEMU Validation PassedAll QEMU validation jobs completed successfully.
Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/34867398794 Boot Time to EFI Shell
Dependencies
This comment was automatically generated by the Patina QEMU PR Validation Post workflow. |
os-d
approved these changes
Sep 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The call should use a variable name, which is stored under "FirmwarePerformance". This updates the get_variable() call to use that name instead of an empty string. Note that was an issue since the initial implementation and not a recent regression. The variable data structure (`FirmwarePerformanceVariable`) should also be packed, so that is done here as well. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
perf_fix_var_name
branch
from
September 14, 2026 16:01
344baf0 to
64cf81a
Compare
makubacki
enabled auto-merge (squash)
September 14, 2026 16:02
vineelko
approved these changes
Sep 14, 2026
Javagedes
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The call should use a variable name, which is stored under "FirmwarePerformance". This updates the get_variable() call to use that name instead of an empty string.
Note that this was an issue in the initial implementation in f632988 and not a recent regression.
The variable data structure (
FirmwarePerformanceVariable) should also be packed, so that is done here as well.How This Was Tested
cargo make all(includes unit test changes)Ran on patina-qemu with
patina_performanceenabled, log level set tolog::LevelFilter::Info, and the following temporary message inreport_fbpt_event():Verified the variable was found sucessfully:
Note that the actual variable (even with the Patina component) is set in
FirmwarePerformanceDataTableDxehere:Integration Instructions