Pull-in upstreamembedded-services changes - #145
Merged
RobertZ2011 merged 1 commit intoSep 25, 2026
Merged
RobertZ2011 merged 1 commit into
RobertZ2011 merged 1 commit into
Conversation
RobertZ2011
changed the title
embedded-services changesembedded-services changes
RobertZ2011
force-pushed
the
pull-in-embedded-services
branch
from
September 24, 2026 22:07
de901fa to
5a81d16
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update the stale feature comment and README reference to the renamed feature.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates ODP integration to use upstream tcpm-interface and tcpm-service names, features, and dependencies.
Changes:
- Renames TCPM imports, traits, features, and example usage.
- Updates RT685S EVK examples and manifests.
- Refreshes dependency lockfiles.
| File | Reviewed changes |
|---|---|
src/odp/service.rs |
Migrates to TCPM service types. |
src/odp/mod.rs |
Updates the TCPM feature gate. |
src/odp/driver.rs |
Updates controller trait implementations. |
examples/rt685s-evk/src/bin/odp/tcpm.rs |
Migrates the TCPM example. |
examples/rt685s-evk/src/bin/odp/tcpm-cfu.rs |
Migrates the CFU example. |
examples/rt685s-evk/Cargo.toml |
Updates example dependencies and features. |
examples/rt685s-evk/Cargo.lock |
Refreshes example dependency resolution. |
Cargo.toml |
Renames dependencies and features. |
Cargo.lock |
Refreshes root dependency resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RobertZ2011
force-pushed
the
pull-in-embedded-services
branch
from
September 24, 2026 22:20
5a81d16 to
2c8498a
Compare
RobertZ2011
marked this pull request as ready for review
September 24, 2026 22:24
RobertZ2011
enabled auto-merge (squash)
September 24, 2026 22:24
tullom
approved these changes
Sep 24, 2026
RobertZ2011
requested review from
felipebalbi,
jerrysxie,
kurtjd and
williampMSFT
September 25, 2026 16:08
RobertZ2011
force-pushed
the
pull-in-embedded-services
branch
from
September 25, 2026 16:10
2c8498a to
d7fbaf8
Compare
kurtjd
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.