Add check for TFUC_VERIFICATION_SLACK_MS - #146
Merged
RobertZ2011 merged 1 commit intoSep 24, 2026
Merged
Conversation
RobertZ2011
force-pushed
the
check-tfuc-timeout-slack
branch
from
September 24, 2026 22:22
9d072ba to
5fba2f0
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds a unit-test assertion ensuring TFUC_VERIFICATION_SLACK_MS remains positive.
Changes:
- Validates the verification slack invariant.
| File | Description |
|---|---|
src/command/mod.rs |
Adds the verification-slack validation assertion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RobertZ2011
marked this pull request as ready for review
September 24, 2026 22:26
RobertZ2011
enabled auto-merge (squash)
September 24, 2026 22:26
RobertZ2011
requested review from
felipebalbi,
jerrysxie,
kurtjd,
tullom and
williampMSFT
September 24, 2026 22:27
kurtjd
approved these changes
Sep 24, 2026
asasine
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.