Support options in browse#2620
Open
PowerfulBacon wants to merge 4 commits into
Open
Conversation
OpenDream side
boring-cyborg
Bot
added
Client
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
PowerfulBacon
commented
Jun 7, 2026
|
|
||
| string htmlFileName; | ||
| if (options?.TryGetValue("file", out var fileName) ?? false) { | ||
| htmlFileName = fileName; |
Contributor
Author
There was a problem hiding this comment.
This needs to remove the extension from the filename, as we add .html ourselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for options being passed through to browse.
The scope of this change is currently quite limited and won't have any practical effect because there is little support for most of the window descriptors, but this will be necessary for TGUI to work properly (as options are passed through in browse instead of through winset).
I tested this by modifying the options of TGUI to pass through the title of 'hello world', as title is a supported parameter:
This does not work with the same code on master:
Prior to this change, the only supported option was
size.Support for explicitly declared file in browse has also been added.