Make error recovery a toggleable error code#2622
Open
amylizzle wants to merge 3 commits into
Open
Conversation
Member
|
Not really sure how I feel about this. This warning was added really early on, when the compiler tripped on all sorts of things. Its existence was more to give an idea of how much of the code was being skipped because of parsing issues. If something is causing this message, but there's no error for it, then that's a bug. |
Collaborator
Author
|
I've only seen it on bad indent, but also at this point it should definitely be a "failed to compile" imo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes a bad test which does not compile on BYOND or OD, it just hits our error recovery
Closes #2616