-
Notifications
You must be signed in to change notification settings - Fork 0
Helm chart thunder #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aravinda-HWK
wants to merge
19
commits into
main
Choose a base branch
from
helm-chart-thunder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d34a4bf
feat: upgrade thunder version to 0.32.0 and update related configurat…
Aravinda-HWK 6ea5fb5
feat: add console runtime configuration and update database path in d…
Aravinda-HWK 84cfe5d
feat: update docker-compose and gen-thunder script for postfix volume…
Aravinda-HWK c8e3789
feat: enhance certbot and OpenDKIM scripts for improved domain handli…
Aravinda-HWK a83075f
feat: remove deprecated Thunder user scripts and update configuration…
Aravinda-HWK a1eebbf
Add script to create a single-page application resource in Thunder
Aravinda-HWK 4150a75
feat: upgrade authentication to use XOAUTH2 and remove password requi…
Aravinda-HWK bdcbee2
feat: update NewMailer function to use sender as username for XOAUTH2…
Aravinda-HWK 0a06c66
refactor: simplify XOAUTH2 user identifier handling in NewMailer
Aravinda-HWK 21cda1e
feat: add OAuth client email authorization configuration and update R…
Aravinda-HWK a1148b7
Merge branch 'main' into 26-feature-upgrade-the-thunder-version-to-th…
Aravinda-HWK 6d4be28
refactor: remove unused sample resource creation logic from script
Aravinda-HWK 72266ee
feat: upgrade server to enforce HTTPS and update related configurations
Aravinda-HWK ef0998b
feat: update email recipient handling to support multiple recipients
Aravinda-HWK 9fb21ea
feat(thunder): add bootstrap ConfigMap and sample resources
Aravinda-HWK e252f1b
feat(thunder): add annotations for ConfigMap pre-install and pre-upgr…
Aravinda-HWK f9c5de3
feat(thunder): add consent server configuration with SQLite support
Aravinda-HWK 4228e44
fix(thunder): update VENDORED.md for clarity on copyright and licensing
Aravinda-HWK 50699a9
Merge remote-tracking branch 'origin/main' into helm-chart-thunder
Aravinda-HWK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| .DS_Store | ||
| .git/ | ||
| .gitignore | ||
| .idea/ | ||
| .vscode/ | ||
| *.tmproj | ||
| *.swp | ||
| *.bak | ||
| # Do NOT add `*.tgz` or `charts/*.tgz` here — they would mask the | ||
| # bundled subchart tarball that Helm reads at install time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| apiVersion: v2 | ||
| name: silver-thunder | ||
| description: | | ||
| Umbrella Helm chart for WSO2 Thunder v0.32.0 (identity / OAuth server) | ||
| used by the Pingmailer / Silver Mail stack. Vendors the upstream | ||
| `thunder` chart at v0.32.0 under charts/thunder/ and bakes this repo's | ||
| bootstrap scripts into a ConfigMap so a single | ||
| `helm install thunder ./mail-infra/helm/thunder` provisions Thunder | ||
| with the default + sample resources matching the docker-compose flow. | ||
| type: application | ||
| version: 0.1.0 | ||
| appVersion: "0.32.0" | ||
|
|
||
| keywords: | ||
| - thunder | ||
| - identity | ||
| - oauth | ||
| - pingmailer | ||
|
|
||
| maintainers: | ||
| - name: LSFLK | ||
| url: https://github.com/lsflk | ||
|
|
||
| sources: | ||
| - https://github.com/thunder-id/thunderid/tree/v0.32.0/install/helm | ||
| - https://github.com/LSFLK/silver | ||
|
|
||
| # The `thunder` subchart is vendored directly under charts/thunder/ (see | ||
| # README — "Vendored subchart"). Declaring it here keeps `helm lint` | ||
| # happy; the empty repository tells Helm to read the local copy without | ||
| # attempting to fetch. No `helm dependency build` step is required. | ||
| dependencies: | ||
| - name: thunder | ||
| version: 0.32.0 | ||
| # `file://.` is a no-op pointer that satisfies the schema check — | ||
| # the subchart is already present under charts/thunder/, so Helm | ||
| # never actually fetches from this repository. | ||
| repository: "file://." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| # silver-thunder Helm chart | ||
|
|
||
| Umbrella chart that wraps the upstream | ||
| [`thunder`](https://github.com/thunder-id/thunderid/tree/v0.32.0/install/helm) | ||
| Helm chart at **v0.32.0** and bakes this repo's bootstrap scripts into a | ||
| ConfigMap so installing Thunder on Kubernetes is the same one-step flow as | ||
| the other mail-plane charts: | ||
|
|
||
| ```bash | ||
| helm upgrade --install thunder ./mail-infra/helm/thunder \ | ||
| --namespace pingmailer --create-namespace \ | ||
| -f my-thunder-values.yaml | ||
| ``` | ||
|
|
||
| No `helm dependency build` step — the subchart is **vendored** under | ||
| `charts/thunder/` so the umbrella chart is fully self-contained. | ||
|
|
||
| ## Version pin | ||
|
|
||
| | | Value | | ||
| |---|---| | ||
| | Subchart | `thunder` v0.32.0 (vendored from [github.com/thunder-id/thunderid @ v0.32.0](https://github.com/thunder-id/thunderid/tree/v0.32.0/install/helm)) | | ||
| | Image | `ghcr.io/asgardeo/thunder:0.32.0` (the only published 0.32.0 image) | | ||
|
|
||
| This matches the version pinned in this repo's | ||
| [docker-compose.yml](../../../docker-compose.yml). To bump to a newer | ||
| Thunder, follow the "Updating the vendored subchart" section below. | ||
|
|
||
| ## Directory layout | ||
|
|
||
| ``` | ||
| mail-infra/helm/thunder/ | ||
| ├── Chart.yaml ← umbrella chart metadata | ||
| ├── values.yaml ← UMBRELLA DEFAULTS (where overrides live) | ||
| ├── values.example.yaml ← starter overlay for users | ||
| ├── README.md ← this file | ||
| ├── .helmignore | ||
| │ | ||
| ├── files/ ← bundled into the bootstrap ConfigMap | ||
| │ ├── 20-default-resources.sh (copy of mail-infra/scripts/thunder/01-...) | ||
| │ └── 30-sample-resources.sh (copy of mail-infra/scripts/thunder/02-...) | ||
| │ | ||
| ├── templates/ ← umbrella's own K8s resources | ||
| │ ├── _helpers.tpl | ||
| │ ├── NOTES.txt | ||
| │ └── bootstrap-configmap.yaml (renders files/*.sh → "thunder-bootstrap" ConfigMap) | ||
| │ | ||
| └── charts/ ← VENDORED upstream — treat as library code | ||
| └── thunder/ (verbatim from thunder-id/thunderid @ v0.32.0) | ||
| ├── Chart.yaml | ||
| ├── values.yaml ← upstream defaults; your overrides go in | ||
| │ ../../values.yaml under `thunder:`, NOT here | ||
| ├── VENDORED.md ← provenance + "don't edit" reminder | ||
| ├── conf/ ← deployment.yaml, console/gate config.js, etc. | ||
| └── templates/ ← 15 Kubernetes resource templates | ||
| ``` | ||
|
|
||
| ### Which `values.yaml` do I edit? | ||
|
|
||
| | File | What it is | Edit? | | ||
| |---|---|---| | ||
| | `values.yaml` (top level) | Umbrella overrides — pre-configures SQLite, persistence, image pin, bootstrap wiring. All keys under `thunder:` flow into the subchart. | **Yes** (or copy `values.example.yaml` to a private overlay) | | ||
| | `charts/thunder/values.yaml` | Vendored upstream defaults (Postgres + HPA + readOnlyRootFilesystem etc.). Library code. | **No** — overlaid by the umbrella | | ||
|
|
||
| ## How it wires together | ||
|
|
||
| - The vendored `thunder` v0.32.0 subchart sits under `charts/thunder/`. | ||
| Helm auto-discovers subcharts there; no `helm dependency build` step is | ||
| required. | ||
| - The two `files/*.sh` are bundled into a `ConfigMap` named | ||
| `thunder-bootstrap` by [templates/bootstrap-configmap.yaml](templates/bootstrap-configmap.yaml) | ||
| via `(.Files.Glob "files/*.sh").AsConfig`. | ||
| - The umbrella's [values.yaml](values.yaml) sets | ||
| `thunder.bootstrap.configMap.name: thunder-bootstrap` and | ||
| `thunder.bootstrap.configMap.files: [20-..., 30-...]` (Pattern 2 — | ||
| additive), so the subchart's setup job mounts our scripts alongside | ||
| its built-in `10-*` defaults. | ||
| - The repo's scripts call `thunder_api_call`. The vendored v0.32.0 | ||
| `common.sh` defines exactly that function (the rename to | ||
| `thunderid_api_call` happened later in 0.38.0+), so no shim is needed. | ||
|
|
||
| Bootstrap script ordering: chart's built-ins `10-*` → ours `20-default-resources.sh` | ||
| → ours `30-sample-resources.sh`. The repo's script already handles 4xx | ||
| responses by falling back to GET, so overlap with the chart's defaults | ||
| is safe. | ||
|
|
||
| ## Source-of-truth note | ||
|
|
||
| `mail-infra/helm/thunder/files/*.sh` is a **copy** of | ||
| `mail-infra/scripts/thunder/*.sh` because Helm's `.Files.Get` only reads | ||
| files inside the chart directory. When you change the canonical scripts, | ||
| re-sync: | ||
|
|
||
| ```bash | ||
| cp mail-infra/scripts/thunder/01-default-resources.sh \ | ||
| mail-infra/helm/thunder/files/20-default-resources.sh | ||
| cp mail-infra/scripts/thunder/02-sample-resources.sh \ | ||
| mail-infra/helm/thunder/files/30-sample-resources.sh | ||
| ``` | ||
|
|
||
| ## Install | ||
|
|
||
| ```bash | ||
| # 1. Author your private overrides (start from values.example.yaml). | ||
| cp mail-infra/helm/thunder/values.example.yaml my-thunder-values.yaml | ||
| $EDITOR my-thunder-values.yaml # set hostname, TLS Secret | ||
|
|
||
| # 2. Install. | ||
| helm upgrade --install thunder ./mail-infra/helm/thunder \ | ||
| --namespace pingmailer --create-namespace \ | ||
| -f my-thunder-values.yaml | ||
| ``` | ||
|
|
||
| ## Required overrides | ||
|
|
||
| The chart prints a `WARNING` in NOTES.txt when these are empty after | ||
| install but does not `fail` outright — the upstream chart owns most of | ||
| the validation logic, and we avoid double error messages. | ||
|
|
||
| | Key | What it controls | | ||
| |---|---| | ||
| | `thunder.configuration.server.publicUrl` | Browser-visible URL Thunder advertises in OAuth metadata | | ||
| | `thunder.configuration.gateClient.hostname` | Hostname used by the Gate frontend | | ||
| | `thunder.configuration.cors.allowedOrigins` | CORS allowlist (typically `["https://<host>"]`) | | ||
| | `thunder.configuration.passkey.allowedOrigins` | WebAuthn RP origin allowlist | | ||
| | `thunder.ingress.hostname` | Ingress host | | ||
| | `thunder.ingress.tlsSecretsName` | Name of a TLS Secret (e.g. from the silver-certificates chart) | | ||
|
|
||
| Note: at v0.32.0 there is **no admin user setup** in the chart itself | ||
| (no `setup.admin.*` block). The repo's `20-default-resources.sh` is | ||
| responsible for creating the admin user, and reads the credentials from | ||
| the script's environment / hardcoded defaults — review the script if you | ||
| need to change them. | ||
|
|
||
| ## Vendored subchart | ||
|
|
||
| The upstream chart was published only as source at the git tag | ||
| [`v0.32.0`](https://github.com/thunder-id/thunderid/tree/v0.32.0/install/helm) | ||
| (later versions moved to OCI as `thunderid` 0.38.0+). To keep the | ||
| single-command install promise, we vendor the source into | ||
| `charts/thunder/` directly. Helm 3 picks it up automatically — no | ||
| `helm dependency build` round trip needed. | ||
|
|
||
| ### Updating the vendored subchart | ||
|
|
||
| To pull a newer point release while staying on 0.32.x (none currently | ||
| published) or a different tag entirely: | ||
|
|
||
| ```bash | ||
| # Replace VERSION with the target tag | ||
| VERSION=v0.32.0 | ||
| curl -sL "https://codeload.github.com/thunder-id/thunderid/tar.gz/refs/tags/${VERSION}" \ | ||
| | tar -xz -C /tmp | ||
| rm -rf mail-infra/helm/thunder/charts/thunder | ||
| cp -R "/tmp/thunderid-${VERSION#v}/install/helm" \ | ||
| mail-infra/helm/thunder/charts/thunder | ||
| ``` | ||
|
|
||
| After updating, re-check `values.yaml` against the new subchart's | ||
| `values.yaml` for schema changes (e.g. flat vs nested SQLite knobs). | ||
|
|
||
| ## Uninstall | ||
|
|
||
| ```bash | ||
| helm uninstall thunder -n pingmailer | ||
| ``` | ||
|
|
||
| The SQLite PVC is preserved. Delete it explicitly to wipe state: | ||
|
|
||
| ```bash | ||
| kubectl -n pingmailer delete pvc -l app.kubernetes.io/instance=thunder | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Copyright (c) 2025, WSO2 LLC. (https://www.wso2.com). | ||
| # | ||
| # WSO2 LLC. licenses this file to you under the Apache License, | ||
| # Version 2.0 (the "License"); you may not use this file except | ||
| # in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| apiVersion: v2 | ||
| name: thunder | ||
| description: A Helm chart for WSO2 Thunder - Lightweight user and identity management system | ||
| type: application | ||
| version: 0.32.0 | ||
| appVersion: "0.32.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # VENDORED — do not edit | ||
|
|
||
| This directory is a verbatim copy of the upstream Thunder Helm chart at the | ||
| [`v0.32.0`](https://github.com/thunder-id/thunderid/tree/v0.32.0/install/helm) | ||
| git tag, copyright © WSO2 LLC. Distributed under the **Apache License, | ||
| Version 2.0** — see [http://www.apache.org/licenses/LICENSE-2.0](http://www.apache.org/licenses/LICENSE-2.0). | ||
| The per-file copyright headers are preserved unchanged. | ||
|
|
||
| It is the **library** that the silver-thunder umbrella wraps. | ||
|
|
||
| - **Configuration overrides go in the umbrella, not here.** Edit | ||
| [`../../values.yaml`](../../values.yaml) (or a private overlay passed | ||
| with `-f`). All keys you set under the `thunder:` block in the | ||
| umbrella's values lay over `./values.yaml` at template-render time. | ||
| - **Updating this directory:** see the "Updating the vendored subchart" | ||
| section of [`../../README.md`](../../README.md) — it's a single | ||
| `curl … | tar -xz` + `cp -R` recipe. | ||
| - **Provenance:** the upstream README (62 KB) and `.helmignore` were | ||
| intentionally removed during vendoring because they aren't needed at | ||
| install time and only added noise. Everything else is bit-identical to | ||
| the upstream tag. |
36 changes: 36 additions & 0 deletions
36
mail-infra/helm/thunder/charts/thunder/conf/apps/console/config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /** | ||
| * Copyright (c) 2025, WSO2 LLC. (https://www.wso2.com). | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| /* eslint-disable no-underscore-dangle */ | ||
|
|
||
| window.__THUNDER_RUNTIME_CONFIG__ = { | ||
| client: { | ||
| base: {{ .Values.configuration.consoleClient.path | quote }}, | ||
| client_id: {{ .Values.configuration.consoleClient.clientId | quote }}, | ||
| scopes: {{ .Values.configuration.consoleClient.scopes }}, | ||
| }, | ||
| server: { | ||
| // Not used when public_url is set | ||
| hostname: "0.0.0.0", | ||
| port: {{ .Values.configuration.server.port }}, | ||
| http_only: {{ .Values.configuration.server.httpOnly }}, | ||
| {{- if .Values.configuration.server.publicUrl }} | ||
| public_url: {{ .Values.configuration.server.publicUrl | quote }}, | ||
| {{- end }} | ||
| }, | ||
| }; | ||
34 changes: 34 additions & 0 deletions
34
mail-infra/helm/thunder/charts/thunder/conf/apps/gate/config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /** | ||
| * Copyright (c) 2025, WSO2 LLC. (https://www.wso2.com). | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| /* eslint-disable no-underscore-dangle */ | ||
|
|
||
| window.__THUNDER_RUNTIME_CONFIG__ = { | ||
| client: { | ||
| base: {{ .Values.configuration.gateClient.path | quote }}, | ||
| }, | ||
| server: { | ||
| // Not used when public_url is set | ||
| hostname: "0.0.0.0", | ||
| port: {{ .Values.configuration.server.port }}, | ||
| http_only: {{ .Values.configuration.server.httpOnly }}, | ||
| {{- if .Values.configuration.server.publicUrl }} | ||
| public_url: {{ .Values.configuration.server.publicUrl | quote }}, | ||
| {{- end }} | ||
| }, | ||
| }; |
57 changes: 57 additions & 0 deletions
57
mail-infra/helm/thunder/charts/thunder/conf/consent-deployment.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # Copyright (c) 2026, WSO2 LLC. (https://www.wso2.com). | ||
| # | ||
| # WSO2 LLC. licenses this file to you under the Apache License, | ||
| # Version 2.0 (the "License"); you may not use this file except | ||
| # in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| server: | ||
| hostname: {{ .Values.configuration.consent.server.hostname | quote }} | ||
| port: {{ .Values.configuration.consent.server.port }} | ||
| readTimeout: 30s | ||
| writeTimeout: 30s | ||
| idleTimeout: 120s | ||
|
|
||
| database: | ||
| consent: | ||
| type: {{ .Values.configuration.consent.database.type | quote }} | ||
| {{- if eq .Values.configuration.consent.database.type "sqlite" }} | ||
| path: {{ .Values.configuration.consent.database.sqlitePath | quote }} | ||
| options: {{ .Values.configuration.consent.database.sqliteOptions | quote }} | ||
| {{- else }} | ||
| hostname: {{ .Values.configuration.consent.database.host | quote }} | ||
| port: {{ .Values.configuration.consent.database.port }} | ||
| database: {{ .Values.configuration.consent.database.name | quote }} | ||
| user: {{ .Values.configuration.consent.database.username | quote }} | ||
| password: {{ "${DB_CONSENT_PASSWORD}" | quote }} | ||
| sslmode: {{ .Values.configuration.consent.database.sslmode | quote }} | ||
| max_open_conns: {{ .Values.configuration.consent.database.max_open_conns }} | ||
| max_idle_conns: {{ .Values.configuration.consent.database.max_idle_conns }} | ||
| conn_max_lifetime: {{ .Values.configuration.consent.database.conn_max_lifetime | quote }} | ||
| {{- end }} | ||
|
|
||
| logging: | ||
| level: info | ||
|
|
||
| consent: | ||
| status_mappings: | ||
| active_status: ACTIVE | ||
| expired_status: EXPIRED | ||
| revoked_status: REVOKED | ||
| created_status: CREATED | ||
| rejected_status: REJECTED | ||
| auth_status_mappings: | ||
| approved_state: APPROVED | ||
| rejected_state: REJECTED | ||
| created_state: CREATED | ||
| system_expired_state: SYS_EXPIRED | ||
| system_revoked_state: SYS_REVOKED |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove this.