-
Notifications
You must be signed in to change notification settings - Fork 44
feat: configure Enterprise SSO for Replicated VM deployments #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jpelletier1
wants to merge
11
commits into
main
Choose a base branch
from
enterprise-sso-vm-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
675d17a
Add Replicated config option for Enterprise SSO (SAML) login
openhands-agent 2d6279e
Auto-configure Keycloak SAML IdP when Enterprise SSO metadata URL is set
openhands-agent 90ca0c2
fix: make automatic SAML provisioning functional
saurya 349b924
test: avoid undeclared YAML dependency
saurya f02db2e
Merge branch 'main' into enterprise-sso-vm-config
aivong-openhands 233807f
fix: address Enterprise SSO review feedback
saurya a99f064
Merge branch 'main' into enterprise-sso-vm-config
aivong-openhands c1ba37d
fix: address Enterprise SSO review findings
saurya b53f613
fix: harden Enterprise SSO reconciliation
saurya 7c02209
Merge branch 'main' into enterprise-sso-vm-config
aivong-openhands ef0b03d
Merge branch 'main' into enterprise-sso-vm-config
aivong-openhands File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| suite: Enterprise SSO wiring | ||
| # The deployment checksums both Keycloak ConfigMaps and always references the | ||
| # LiteLLM script, so all four templates participate in these render tests. | ||
| templates: | ||
| - deployment.yaml | ||
| - keycloak-config-script.yaml | ||
| - keycloak-realm-template.yaml | ||
| - litellm-config-script.yaml | ||
| tests: | ||
| - it: advertises and auto-configures Enterprise SSO from metadata | ||
| set: | ||
| enabled: true | ||
| keycloak.enabled: true | ||
| enterpriseSSO.enabled: true | ||
| enterpriseSSO.displayName: Company SSO | ||
| enterpriseSSO.idpMetadataUrl: https://idp.example.com/saml/metadata | ||
| asserts: | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OH_WEB_CLIENT_PROVIDERS_CONFIGURED | ||
| value: '["enterprise_sso"]' | ||
| - template: keycloak-config-script.yaml | ||
| matchRegex: | ||
| path: data["keycloak-config.sh"] | ||
| pattern: 'Content-Type: application/json' | ||
| - template: keycloak-config-script.yaml | ||
| matchRegex: | ||
| path: data["keycloak-config.sh"] | ||
| pattern: 'validateSignature.*true' | ||
| - template: keycloak-config-script.yaml | ||
| notMatchRegex: | ||
| path: data["keycloak-config.sh"] | ||
| pattern: 'validateSignatures' | ||
|
|
||
| - it: advertises Enterprise SSO without managing Keycloak when metadata is blank | ||
| set: | ||
| enabled: true | ||
| keycloak.enabled: true | ||
| enterpriseSSO.enabled: true | ||
| enterpriseSSO.idpMetadataUrl: "" | ||
| asserts: | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OH_WEB_CLIENT_PROVIDERS_CONFIGURED | ||
| value: '["enterprise_sso"]' | ||
| - template: keycloak-config-script.yaml | ||
| notMatchRegex: | ||
| path: data["keycloak-config.sh"] | ||
| pattern: 'ENTERPRISE_SSO_IDP_METADATA_URL' | ||
|
|
||
| - it: disables a managed provider when the feature toggle is off | ||
| set: | ||
| enabled: true | ||
| keycloak.enabled: true | ||
| enterpriseSSO.enabled: false | ||
| enterpriseSSO.idpMetadataUrl: https://idp.example.com/saml/metadata | ||
| asserts: | ||
| - template: deployment.yaml | ||
| notExists: | ||
| path: spec.template.spec.containers[0].env[?(@.name=="OH_WEB_CLIENT_PROVIDERS_CONFIGURED")] | ||
| - template: keycloak-config-script.yaml | ||
| matchRegex: | ||
| path: data["keycloak-config.sh"] | ||
| pattern: 'Disabled managed identity provider: enterprise_sso' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.