Repository navigation
feat: PLTF-3553 Add Helm values for org condenser defaults #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aivong-openhands
merged 10 commits into
main
from
openhands-org-condenser-defaults-chart-20260909
Sep 11, 2026
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f16eb02
Add Helm org condenser default settings
openhands-agent 848f9a9
Address org condenser chart feedback
openhands-agent 842cd5f
Merge branch 'main' into openhands-org-condenser-defaults-chart-20260909
aivong-openhands 6d0a05c
Merge branch 'main' into openhands-org-condenser-defaults-chart-20260909
aivong-openhands d7de21c
fix: nil-safe org condenser guards, drop invented maxTokens ceiling
openhands-agent 9907d95
Merge branch 'main' into openhands-org-condenser-defaults-chart-20260909
aivong-openhands cb9f6b0
docs: clarify org condenser reconciliation trigger and target version
openhands-agent f12c06c
fix: coerce org condenser maxTokens to an integer before quoting
openhands-agent 037b7d5
Merge branch 'main' into openhands-org-condenser-defaults-chart-20260909
aivong-openhands 1c87257
docs: clarify org condenser removal order
openhands-agent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
charts/openhands/tests/org_defaults_condenser_test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| suite: org defaults condenser env wiring | ||
| templates: | ||
| - deployment.yaml | ||
| - litellm-config-script.yaml | ||
| tests: | ||
| - it: leaves org condenser env unset by default | ||
| set: | ||
| enabled: true | ||
| asserts: | ||
| - template: deployment.yaml | ||
| notExists: | ||
| path: spec.template.spec.containers[0].env[?(@.name=="OPENHANDS_ORG_DEFAULTS_CONDENSER_MAX_TOKENS")] | ||
| - template: deployment.yaml | ||
| notExists: | ||
| path: spec.template.spec.containers[0].env[?(@.name=="OPENHANDS_ORG_DEFAULTS_CONDENSER_APPLY_TO_EXISTING")] | ||
| - template: deployment.yaml | ||
| notExists: | ||
| path: spec.template.spec.containers[0].env[?(@.name=="OPENHANDS_ORG_DEFAULTS_CONDENSER_OVERWRITE_EXISTING")] | ||
|
|
||
| - it: renders without org condenser env when the orgDefaults block is null | ||
| set: | ||
| enabled: true | ||
| orgDefaults: null | ||
| asserts: | ||
| - template: deployment.yaml | ||
| notExists: | ||
| path: spec.template.spec.containers[0].env[?(@.name=="OPENHANDS_ORG_DEFAULTS_CONDENSER_MAX_TOKENS")] | ||
|
|
||
| - it: renders without org condenser env when the condenser block is null | ||
| set: | ||
| enabled: true | ||
| orgDefaults: | ||
| condenser: null | ||
| asserts: | ||
| - template: deployment.yaml | ||
| notExists: | ||
| path: spec.template.spec.containers[0].env[?(@.name=="OPENHANDS_ORG_DEFAULTS_CONDENSER_MAX_TOKENS")] | ||
|
|
||
| - it: wires false rollout flags when only a threshold is configured | ||
| set: | ||
| enabled: true | ||
| orgDefaults.condenser.maxTokens: 200000 | ||
| asserts: | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OPENHANDS_ORG_DEFAULTS_CONDENSER_MAX_TOKENS | ||
| value: "200000" | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OPENHANDS_ORG_DEFAULTS_CONDENSER_APPLY_TO_EXISTING | ||
| value: "false" | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OPENHANDS_ORG_DEFAULTS_CONDENSER_OVERWRITE_EXISTING | ||
| value: "false" | ||
|
|
||
| - it: defaults null rollout flags to false rather than an empty value | ||
| set: | ||
| enabled: true | ||
| orgDefaults.condenser.maxTokens: 200000 | ||
| orgDefaults.condenser.applyToExisting: null | ||
| orgDefaults.condenser.overwriteExisting: null | ||
| asserts: | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OPENHANDS_ORG_DEFAULTS_CONDENSER_APPLY_TO_EXISTING | ||
| value: "false" | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OPENHANDS_ORG_DEFAULTS_CONDENSER_OVERWRITE_EXISTING | ||
| value: "false" | ||
|
|
||
| - it: renders an exponent-notation threshold as a plain integer | ||
| set: | ||
| enabled: true | ||
| orgDefaults: | ||
| condenser: | ||
| maxTokens: 1.0e+6 | ||
| asserts: | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OPENHANDS_ORG_DEFAULTS_CONDENSER_MAX_TOKENS | ||
| value: "1000000" | ||
|
|
||
| - it: wires configured org condenser rollout settings | ||
| set: | ||
| enabled: true | ||
| orgDefaults.condenser.maxTokens: 200000 | ||
| orgDefaults.condenser.applyToExisting: true | ||
| orgDefaults.condenser.overwriteExisting: true | ||
| asserts: | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OPENHANDS_ORG_DEFAULTS_CONDENSER_MAX_TOKENS | ||
| value: "200000" | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OPENHANDS_ORG_DEFAULTS_CONDENSER_APPLY_TO_EXISTING | ||
| value: "true" | ||
| - template: deployment.yaml | ||
| contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: OPENHANDS_ORG_DEFAULTS_CONDENSER_OVERWRITE_EXISTING | ||
| value: "true" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.