fix: resolve plugin presets before conversation start - #339
Open
ShivangiRay wants to merge 1 commit into
Open
Conversation
Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve and validate plugin sources in the plugin-preset runner before creating the remote conversation. The conversation receives verified local paths rather than remote coordinates, preventing lazy server-side fetch failures from surfacing as opaque errors during event polling.
Root cause
Plugin presets passed remote plugin coordinates directly to the in-sandbox agent server. Plugin fetching happens lazily when the conversation starts, so failures appear as 500 responses while reading conversation events.
Validation
uv run pytest tests/test_preset_router.py -q(97 passed, 41 skipped)pre-commit run --files openhands/automation/presets/plugin/sdk_main.py tests/test_preset_router.py --show-diff-on-failureRelated: OpenHands/OpenHands#16611
AI assistance was used to prepare this change; the submitter reviewed the diff and test results.