Repository navigation
fix(migrations): renumber instance_id migration to 209 - #1126
Merged
Merged
Conversation
|
|
jlav
enabled auto-merge (squash)
November 2, 2026 16:53
aivong-openhands
approved these changes
Nov 2, 2026
The openhands logger is configured with propagate=False, so pytest's caplog attaches its handler directly to it. Setting propagate=True mid-test also sent each record to the root logger, which holds the same caplog handler, so every warning was captured twice and the single-record unpacking failed. Co-authored-by: openhands <openhands@all-hands.dev>
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
2 of 6 tasks
Contributor
|
🚀 Released in 1.83.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
AGENT:
Why
mainhas two migrations with revision207, and both revise206. #1119 added207_add_startup_title_generation.py, and #1114 added207_add_instance_id_to_instance_settings.py. Then #1121 put208on top of one of them.Alembic now sees two heads, so
alembic upgrade headfails. The app crashes at startup whenRUN_MIGRATIONS_ON_STARTUP=true, so the docker compose stack doesn't come up. The unit test DB template can't migrate either.Summary
209and setsdown_revisionto208, so the chain is linear again with one head.Issue Number
How to Test
uv run alembic headsprints only209 (head).docker compose -f docker-compose.yml -f docker-compose.build.yml up -d --buildbrings the app up healthy. The DB ends at209withinstance_settings.instance_idpresent.uv run pytest tests/unit/test_migration_graph.py tests/unit/test_enterprise_migration_integrity.py tests/unit/test_migration_207_startup_titles.pypasses. Onmainthese error while building the test DB template.Video/Screenshots
Type
Notes
#1114 merged after #1121, so a database migrated from
mainbefore #1114 is already at208. On that database,upgrade headonly runs209.Enterprise server image for this PR: