fix(sdk): re-arm triggered skills after condensation - #4552
Draft
uuzzrm wants to merge 1 commit into
Draft
Conversation
Rebuild trigger deduplication state from the active view after condensation so forgotten keyword skills and path rules can be injected again on a later matching trigger. Keep the existing once-per-view behavior for triggers whose activation events remain visible.\n\nFixes OpenHands#4544\n\nCo-authored-by: openhands <openhands@all-hands.dev>
Contributor
|
📁 PR Artifacts Notice This PR contains a |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
AGENT:
This PR was prepared by an AI agent (OpenAI Codex) on behalf of
uuzzrm. The implementation and verification details are included below.Why
Triggered knowledge skills and path-scoped rules are currently deduplicated for the entire conversation. If condensation forgets the event that carried the trigger content, the deduplication marker remains in
ConversationState, so later matching triggers are silently skipped.Summary
Condensationevent is applied.LocalConversation.condense().Issue Number
Fixes #4544
How to Test
The regression tests exercise the real
LocalConversation.condense()path with anLLMSummarizingCondenser, persisted events, active-view condensation, and a subsequent matching trigger.The focused command completed with 52 passed tests.
tests/sdk/conversation/goal/test_render_transcript.pyalso passed independently. A fulltests/sdk/conversationrun was attempted, but the local test run exhausted temporary-disk space before it could produce a final directory-wide result; no full-suite pass is claimed.Video/Screenshots
Not applicable for this SDK behavior change.
Design Doc
Not required for this focused bug fix.
Type
Notes
HUMAN:note in their own words.