Skip to content

feat(sdk): enforce disabled_agents deny-list at sub-agent spawn time #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgeglarson wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(sdk): enforce disabled_agents deny-list at sub-agent spawn time #4557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f6a9422
feat(sdk): enforce disabled_agents deny-list at sub-agent spawn time
georgeglarson Aug 20, 2026
a1ce77c
chore(pr): add live-demo evidence for disabled_agents enforcement
georgeglarson Aug 20, 2026
5fca58f
chore(pr): add live-LLM e2e for disabled_agents (GLM-4.7 refusal + re…
georgeglarson Aug 20, 2026
e11b9ec
chore(pr): fix e2e refusal scanner; rerun shows retry with allowed type
georgeglarson Aug 20, 2026
5a9516f
chore(pr): extract final agent response with SDK helper in e2e
georgeglarson Aug 20, 2026
dfa1800
refactor(tools): make disabled-agent refusal a first-class tool error
georgeglarson Aug 20, 2026
3d6084c
Merge branch 'main' into feat-agent-context-disabled-agents
georgeglarson Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions .pr/demo-logs/branch-demo1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
+----------------------------------------------------------------------+
| OpenHands SDK v1.42.1 |
| |
| Report a bug: github.com/OpenHands/software-agent-sdk/issues |
| Get help: openhands.dev/joinslack |
| Scale up: openhands.dev/product/sdk |
| |
| Set OPENHANDS_SUPPRESS_BANNER=1 to hide this message |
+----------------------------------------------------------------------+

[08/20/26 08:27:26] INFO Registered file-based agent default.py:148
'bash-runner' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/bash_runner.md
[08/20/26 08:27:26] INFO Registered file-based agent default.py:148
'code-explorer' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/code_explorer.
md
[08/20/26 08:27:26] INFO Registered file-based agent default.py:148
'general-purpose' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/default.md
[08/20/26 08:27:26] INFO Registered file-based agent default.py:148
'web-researcher' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/web_researcher
.md
[08/20/26 08:27:26] WARNING No persistence_dir provided; falling state.py:506
back to InMemoryFileStore. EventLog
data will not persist across requests.
[08/20/26 08:27:26] INFO Created new conversation state.py:583
37cf66eb-1e92-4ceb-abfb-405d4911e66a
[08/20/26 08:27:26] INFO Task refused (disabled_agents): impl.py:59
Sub-agent 'general-purpose' is disabled
for this conversation
(agent_context.disabled_agents). Choose
another sub-agent type.
[08/20/26 08:27:26] INFO Created new conversation state.py:583
2675c468-c8f4-4e7b-a73f-ece5074b7869
[08/20/26 08:27:26] INFO Confirmation policy set local_conversation.py:2542
to: kind='NeverConfirm'
=== 1. Can the preference even be expressed? ===
AgentContext(disabled_agents=['general-purpose']) -> ['general-purpose']

=== 2. Does anything stop the spawn? (no LLM involved) ===
refused: Sub-agent 'general-purpose' is disabled for this conversation (agent_context.disabled_agents). Choose another sub-agent type.

=== 3. What the calling LLM sees (full tool path, TaskExecutor) ===
is_error=True
text: Failed to execute task: Sub-agent 'general-purpose' is disabled for this conversation (agent_context.disabled_agents). Choose another sub-agent type.

=== 4. A type not on the list still spawns ===
spawned: task_00000001 status=running

=== 5. delegate tool spawn path ===
is_error=True
text: Sub-agent type(s) disabled for this conversation: general-purpose (agent_context.disabled_agents). Choose another agent type.
58 changes: 58 additions & 0 deletions .pr/demo-logs/branch-demo2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
+----------------------------------------------------------------------+
| OpenHands SDK v1.42.1 |
| |
| Report a bug: github.com/OpenHands/software-agent-sdk/issues |
| Get help: openhands.dev/joinslack |
| Scale up: openhands.dev/product/sdk |
| |
| Set OPENHANDS_SUPPRESS_BANNER=1 to hide this message |
+----------------------------------------------------------------------+

[08/20/26 08:27:29] INFO Registered file-based agent default.py:148
'bash-runner' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/bash_runner.md
[08/20/26 08:27:29] INFO Registered file-based agent default.py:148
'code-explorer' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/code_explorer.
md
[08/20/26 08:27:29] INFO Registered file-based agent default.py:148
'general-purpose' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/default.md
[08/20/26 08:27:29] INFO Registered file-based agent default.py:148
'web-researcher' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/web_researcher
.md
[08/20/26 08:27:29] WARNING No persistence_dir provided; falling state.py:506
back to InMemoryFileStore. EventLog
data will not persist across requests.
[08/20/26 08:27:29] INFO Created new conversation state.py:583
357ddfd8-d9c4-4066-a754-1d79a772d8f6
[08/20/26 08:27:29] INFO Created new conversation state.py:583
8941a79b-9d99-43f8-9bfa-085716fc7857
[08/20/26 08:27:29] INFO Confirmation policy set local_conversation.py:2542
to: kind='NeverConfirm'
[08/20/26 08:27:29] INFO Agent execution pause local_conversation.py:2654
requested
[08/20/26 08:27:29] WARNING Unrecognized event file name: event_store.py:300
.eventlog.lock
[08/20/26 08:27:29] INFO Resumed conversation state.py:558
8941a79b-9d99-43f8-9bfa-085716fc7857
from persistent storage
[08/20/26 08:27:29] INFO Confirmation policy set local_conversation.py:2542
to: kind='NeverConfirm'
=== Beat 1: resume with a since-disabled type ===
created + evicted task_00000001 (type was 'default')
resume as 'general-purpose': refused: Sub-agent 'general-purpose' is disabled for this conversation (agent_context.disabled_agents). Choose another sub-agent type.
resume as 'default': running (resume itself works)

=== Beat 2: the wire path (what a frontend POST carries) ===
client sends: agent_settings.agent_context = {'disabled_agents': ['general-purpose']}
server-side agent.agent_context.disabled_agents = ['general-purpose']
98 changes: 98 additions & 0 deletions .pr/demo-logs/e2e-live-glm-4.7.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
+----------------------------------------------------------------------+
| OpenHands SDK v1.42.1 |
| |
| Report a bug: github.com/OpenHands/software-agent-sdk/issues |
| Get help: openhands.dev/joinslack |
| Scale up: openhands.dev/product/sdk |
| |
| Set OPENHANDS_SUPPRESS_BANNER=1 to hide this message |
+----------------------------------------------------------------------+

[08/20/26 08:27:32] INFO Registered file-based agent default.py:148
'bash-runner' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/bash_runner.md
[08/20/26 08:27:32] INFO Registered file-based agent default.py:148
'code-explorer' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/code_explorer.
md
[08/20/26 08:27:32] INFO Registered file-based agent default.py:148
'general-purpose' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/default.md
[08/20/26 08:27:32] INFO Registered file-based agent default.py:148
'web-researcher' from
/home/glitchenstein/repos/software-a
gent-sdk/openhands-tools/openhands/t
ools/preset/subagents/web_researcher
.md
[08/20/26 08:27:32] WARNING No persistence_dir provided; falling state.py:506
back to InMemoryFileStore. EventLog
data will not persist across requests.
[08/20/26 08:27:32] INFO Created new conversation state.py:583
c28d0b1a-e60c-4abd-9cb5-6b67f7a4f8d7
[08/20/26 08:27:32] INFO Loaded 1 tools from spec base.py:563
[08/20/26 08:27:32] INFO [Profile Store] Loaded llm_profile_store.py:302
profile `kimi` from
/home/glitchenstein/.openh
ands/profiles/kimi.json
[08/20/26 08:27:32] INFO [Profile Store] Loaded llm_profile_store.py:302
profile `mimo` from
/home/glitchenstein/.openh
ands/profiles/mimo.json
[08/20/26 08:27:32] INFO [Profile Store] Loaded llm_profile_store.py:302
profile `minimax` from
/home/glitchenstein/.openh
ands/profiles/minimax.json
/home/glitchenstein/repos/software-agent-sdk/openhands-sdk/openhands/sdk/llm/utils/telemetry.py:291: UserWarning: Cost calculation failed: This model isn't mapped yet. model=glm-4.7, custom_llm_provider=openai. Add it here - https://github.com/BerriAI/litellm/blob/main/model_prices_and_context_window.json.
warnings.warn(f"Cost calculation failed: {e}")
[08/20/26 08:27:38] INFO Task refused (disabled_agents): impl.py:59
Sub-agent 'code-explorer' is disabled
for this conversation
(agent_context.disabled_agents). Choose
another sub-agent type.
[08/20/26 08:27:42] INFO Created new conversation state.py:583
28e4a49d-eac1-4dc1-845a-036fcf5a1cc5
[08/20/26 08:27:42] INFO Confirmation policy set local_conversation.py:2542
to: kind='NeverConfirm'
[08/20/26 08:27:42] INFO TaskTrackerExecutor initialized definition.py:161
with save_dir:
/tmp/openhands_tasks_uamzbq7p/28e
4a49deac14dc1845a036fcf5a1cc5
[08/20/26 08:27:42] INFO FileEditor initialized with cwd: editor.py:105
/tmp/e2e_disabled_agents_laft4v7w
[08/20/26 08:27:42] INFO TmuxPanePool initialized: tmux_pane_pool.py:140
session=openhands-pool-None-e
c285348-69ed-414c-8412-96336e
ee19b2, max_panes=4
[08/20/26 08:27:42] INFO TerminalExecutor initialized (pool impl.py:145
mode) working_dir:
/tmp/e2e_disabled_agents_laft4v7w,
username: None, max_panes: 4
[08/20/26 08:27:42] INFO Loaded 3 tools from spec base.py:563
[08/20/26 08:27:42] INFO [Profile Store] Loaded llm_profile_store.py:302
profile `kimi` from
/home/glitchenstein/.openh
ands/profiles/kimi.json
[08/20/26 08:27:42] INFO [Profile Store] Loaded llm_profile_store.py:302
profile `mimo` from
/home/glitchenstein/.openh
ands/profiles/mimo.json
[08/20/26 08:27:42] INFO [Profile Store] Loaded llm_profile_store.py:302
profile `minimax` from
/home/glitchenstein/.openh
ands/profiles/minimax.json
/home/glitchenstein/repos/software-agent-sdk/openhands-sdk/openhands/sdk/llm/utils/telemetry.py:291: UserWarning: Cost calculation failed: This model isn't mapped yet. model=glm-4.7, custom_llm_provider=openai. Add it here - https://github.com/BerriAI/litellm/blob/main/model_prices_and_context_window.json.
warnings.warn(f"Cost calculation failed: {e}")
[08/20/26 08:27:50] INFO Task 'task_00000001' completed. manager.py:413
=== E2E RESULT ===
task tool calls by subagent_type: ['code-explorer', 'general-purpose']
refusals observed: 1
-> Failed to execute task: Sub-agent 'code-explorer' is disabled for this conversation (agent_context.disabled_agents). Choose another sub-agent type.
final status: ConversationExecutionStatus.FINISHED
cost: $0.0000
final agent response: I calculated 17 * 23 = 391 using the task tool. The answer is 391.
Loading
Loading