Clean up CodeQL js/ warnings in commons UI#298
Merged
vharseko merged 1 commit intoJul 23, 2026
Conversation
Resolve five CodeQL js/ alerts in first-party UI code (no behavior change): - ViewManager.js: drop redundant 'cDialog !== null' next to the truthiness check (js/comparison-between-incompatible-types). - LoginTemplate.html: remove the duplicated type="checkbox" attribute on the loginRemember input (js/duplicate-html-attribute). - Messages.js: drop the unused initial 'alert-info' value of alertClass, which the switch (including its default branch) always overwrites (js/useless-assignment-to-local). - UIUtils.js: remove the repeated '!' from the isUrl regex character class (js/regex/duplicate-in-character-class). - UserProfileKBATab.js: simplify the always-true inner 'isKbaQuestion' term in the KBA validation guard (js/trivial-conditional).
vharseko
added
codeql
maximthomas
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves five CodeQL
js/code-scanning alerts in first-party UI code. All changes are behavior-preserving cleanups of dead/redundant code.js/comparison-between-incompatible-typesViewManager.js— drop redundantcDialog !== nullnext to the truthiness checkjs/duplicate-html-attributeLoginTemplate.html— remove duplicatedtype="checkbox"on the loginRemember inputjs/useless-assignment-to-localMessages.js— drop unused initialalert-infovalue; the switch (with itsdefault) always overwritesalertClassjs/regex/duplicate-in-character-classUIUtils.js— remove the repeated!in theisUrlregex character classjs/trivial-conditionalUserProfileKBATab.js— simplify the always-true innerisKbaQuestionterm in the KBA guardNote
The remaining open
js/alerts are all insidecommons/rest/openapi-war-overlay/(vendored handlebars/marked/swagger-oauth) and are addressed by removing that module in a separate branch, so they are intentionally not touched here.