Varien_Data_Collection_Db: fix type for _map property - #5606
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Varien_Data_Collection_Db’s $_map PHPDoc to reflect its real runtime structure (including Zend_Db_Expr mappings) and adjusts addFilterToMap() initialization logic to avoid accessing an undefined group key. The PHPStan baseline is updated accordingly by removing now-unneeded ignores.
Changes:
- Broadened
$_mapproperty type from a fixedfields-only shape to a generic group map that supportsstring|Zend_Db_Exprvalues. - Replaced a potentially undefined-offset null check with an
array_key_exists()group presence check inaddFilterToMap(). - Removed PHPStan baseline suppressions that were only required due to the previous
$_maptype.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/Varien/Data/Collection/Db.php |
Fixes $_map typing to match actual usage and makes addFilterToMap() group initialization safe. |
.phpstan.dist.baselines/assign.propertyType.php |
Drops baseline ignores that should no longer trigger after the type correction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)