Skip to content

phpStan: update escapeHtml() docs #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sreichel wants to merge 5 commits into
base: main
Choose a base branch
from
Open

phpStan: update escapeHtml() docs #5609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69eccde
phpStan: update `escapeHtml()` docs
sreichel May 22, 2026
0a96d15
cs
sreichel May 22, 2026
669b143
update
sreichel May 22, 2026
90db776
update
sreichel May 22, 2026
a094ddd
rector
sreichel May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
440 changes: 0 additions & 440 deletions .phpstan.dist.baselines/argument.type.php
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 0 additions & 5 deletions .phpstan.dist.baselines/assignOp.invalid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
<?php declare(strict_types = 1);

$ignoreErrors = [];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation ".=" between array<string|null>|string|null and non-falsy-string results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "*=" between float|string and 1 results in an error.',
'count' => 1,
Expand Down
180 changes: 0 additions & 180 deletions .phpstan.dist.baselines/binaryOp.invalid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,141 +16,16 @@
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<optgroup label="\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Websites.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<optgroup label="…\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Websites.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<span title="\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Dashboard/Searches/Renderer/Searchquery.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'[\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Newsletter/Template/Grid/Renderer/Sender.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between array<string|null>|string|null and \' \' results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Newsletter/Template/Grid/Renderer/Sender.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<br />\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Notice.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<span class="grid…\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Notice.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<span class="grid…\' and array|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Severity.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Group.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Store.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Website.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "*" between string and 1 results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid/Renderer/Data.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Urlrewrite/Link.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<optgroup label="\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<option value="\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<optgroup label="\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Store.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<optgroup label="…\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Store.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Store.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Abstract.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<option value="\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Select.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<select name="\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Select.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between array<string|null>|string|null and \'</option>\' results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Select.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/View/Items/Renderer.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Bundle/Block/Sales/Order/Items/Renderer.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Catalog/Block/Product/View/Options/Type/Select.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'e.\' and int|Mage_Eav_Model_Entity_Attribute_Interface|string results in an error.',
'count' => 1,
Expand Down Expand Up @@ -181,16 +56,6 @@
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<li title="\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/CatalogSearch/Block/Autocomplete.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between array<string|null>|string|null and \'</li>\' results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/CatalogSearch/Block/Autocomplete.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "+" between int|string and 1 results in an error.',
'count' => 2,
Expand All @@ -201,11 +66,6 @@
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Core/Block/Abstract.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'value="\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Core/Block/Html/Date.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'/\' and non-empty-array|non-falsy-string results in an error.',
'count' => 1,
Expand Down Expand Up @@ -286,11 +146,6 @@
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Log/Model/Resource/Visitor/Online.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Page/Block/Html/Topmenu.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "-" between float|string and float|string results in an error.',
'count' => 1,
Expand All @@ -306,11 +161,6 @@
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Paypal/Model/Ipn.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \'<br/> Coupon Code: \' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Rss/Block/Catalog/Salesrule.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array|int|string|null results in an error.',
'count' => 1,
Expand All @@ -321,16 +171,6 @@
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Rule/Model/Condition/Combine.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Sales/Block/Order/Email/Items/Default.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Sales/Block/Order/Email/Items/Order/Default.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "+" between float|string and float|string results in an error.',
'count' => 1,
Expand All @@ -341,11 +181,6 @@
'count' => 2,
'path' => __DIR__ . '/../app/code/core/Mage/Sales/Model/Order/Payment.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between non-falsy-string and array<string|null>|string|null results in an error.',
'count' => 2,
'path' => __DIR__ . '/../app/code/core/Mage/Usa/Block/Adminhtml/System/Config/Form/Field/Usps/AbstractTestButton.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "*" between float and string results in an error.',
'count' => 2,
Expand All @@ -356,21 +191,6 @@
'count' => 1,
'path' => __DIR__ . '/../app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between array<string|null>|string|null and string results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/design/adminhtml/base/default/template/catalog/category/edit/form.phtml',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between \' (\' and array<string|null>|string|null results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/design/adminhtml/base/default/template/sales/order/view/info.phtml',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "." between array<string|null>|string|null and string results in an error.',
'count' => 1,
'path' => __DIR__ . '/../app/design/adminhtml/base/default/template/sales/order/view/info.phtml',
];
$ignoreErrors[] = [
'rawMessage' => 'Binary operation "+" between string|false|null and 1 results in an error.',
'count' => 1,
Expand Down
Loading
Loading