Skip to content

add TypeInfo to base Generator functions #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hanmac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add TypeInfo to base Generator functions #5715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions .phpstan.dist.baselines/missingType.generics.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,11 +1101,6 @@
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Catalog/Model/Product/Option/Type/TextTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Catalog\\Model\\ProductTest::provideBool() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Catalog/Model/ProductTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Catalog\\Model\\ProductTest::provideFormatUrlKey() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
Expand Down Expand Up @@ -1141,26 +1136,6 @@
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Catalog/Model/UrlTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Catalog\\Model\\UrlTest::provideIntOrNull() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Catalog/Model/UrlTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Cms\\Block\\BlockTest::provideNumericString() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Cms/Block/BlockTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Cms\\Block\\PageTest::provideNumericString() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Cms/Block/PageTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Cms\\Block\\Widget\\BlockTest::provideNumericString() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Cms/Block/Widget/BlockTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Cms\\Block\\Widget\\Page\\LinkTest::provideGetAnchorTextData() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
Expand Down Expand Up @@ -1321,11 +1296,6 @@
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Core/Model/ConfigTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Core\\Model\\Layout\\ValidatorTest::provideUrl() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Core/Model/Layout/ValidatorTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Core\\Model\\LayoutTest::provideCreateBlock() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
Expand Down Expand Up @@ -1401,11 +1371,6 @@
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Core/Model/StoreTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Core\\Model\\Url\\ValidatorTest::provideUrl() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Core/Model/Url/ValidatorTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Customer\\Block\\Widget\\DobTest::provideGetYearData() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
Expand Down Expand Up @@ -1486,11 +1451,6 @@
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Review/Model/ReviewTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Rule\\Model\\AbstractTest::provideBool() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
'path' => __DIR__ . '/../tests/unit/Mage/Rule/Model/AbstractTest.php',
];
$ignoreErrors[] = [
'rawMessage' => 'Method OpenMage\\Tests\\Unit\\Mage\\Rule\\Model\\AbstractTest::provideValidateData() return type with generic class Generator does not specify its types: TKey, TValue, TSend, TReturn',
'count' => 1,
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/Traits/DataProvider/Base/BoolTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@

trait BoolTrait
{
/**
* @return Generator<string, list{bool}, void, void>
*/
public static function provideBool(): Generator
{
yield 'true' => [
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/Traits/DataProvider/Base/IntOrNullTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@

trait IntOrNullTrait
{
/**
* @return Generator<string, list{?int}, void, void>
*/
public static function provideIntOrNull(): Generator
{
yield 'null' => [
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/Traits/DataProvider/Base/NumericStringTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@

trait NumericStringTrait
{
/**
* @return Generator<string, list{numeric-string}, void, void>
*/
public static function provideNumericString(): Generator
{
yield 'zero' => [
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/Traits/DataProvider/Base/UrlTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@

trait UrlTrait
{
/**
* @return Generator<string, list{bool, string}, void, void>
*/
public static function provideUrl(): Generator
{
yield 'invalid empty' => [
Expand Down
Loading