Conversation
indigo423
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring OpenNMS logging output format in JSON, allowing users to choose between plain text, JSON, or null console output for both startup and daemon logging.
Key Changes
- Added five new configuration parameters for logging format control and instance identification
- Updated the Helm chart version from 1.1.17 to 1.1.18
- Added schema validation for the new logging output format options
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| horizon/values.yaml | Added default values for new logging configuration parameters |
| horizon/values.schema.json | Added JSON schema validation for new logging and instance configuration fields |
| horizon/templates/app-settings.configmap.yaml | Exposed new configuration values as environment variables in the ConfigMap |
| horizon/README.md | Updated documentation to include the new configuration options |
| horizon/Chart.yaml | Bumped chart version to reflect new features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ME.md, and app-settings.configmap.yaml
Signed-off-by: Ronny Trommer <ronny@no42.org>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mershad-manesh
left a comment
mershad-manesh
left a comment
There was a problem hiding this comment.
Looks good to me :)
This PR adds support for configuring OpenNMS logging output format in JSON, allowing users to choose between plain text, JSON, or null console output for both startup and daemon logging.
Key Changes
Resolves: #66