Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables users to configure the OpenNMS instance ID when multi-tenant mode is disabled. Previously, the instance ID was always empty in single-tenant mode.
Key changes:
- Added a new
instanceIdconfiguration parameter (default: "OpenNMS") undercore.configuration - Updated the app-settings ConfigMap template to use the configured instance ID when
multiTenant=false - Fixed spelling of "Kafka" in documentation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| horizon/values.yaml | Added instanceId configuration parameter and fixed "Kafka" spelling |
| horizon/values.schema.json | Added JSON schema definition for the new instanceId parameter |
| horizon/templates/app-settings.configmap.yaml | Updated to use configured instance ID in single-tenant mode |
| horizon/README.md | Documented new parameter and fixed "Kafka" spelling |
| horizon/Chart.yaml | Bumped chart version to 1.1.18 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2b2e796 to
191f9c0
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When multitenant mode is disabled, allow users to control the OpenNMS Instance ID with a configuration in the values.yaml file. Resolves: #75 Signed-off-by: Ronny Trommer <ronny@no42.org>
When multitenant mode is disabled, allow users to control the OpenNMS Instance ID with a configuration in the values.yaml file.
Reviewer hint
We keep the multi-tenant logic with the releaseName as the instance ID when multiTenant is true.
Resolves: #75