NMS-20124: point the notification bell at the new Notifications page by joseanesONMS · Pull Request #8719 · OpenNMS/opennms

joseanesONMS · 2026-07-31T17:28:34Z

Tickets: NMS-20124 (epic NMS-20100).

Points the top-bar notification bell at the new Notifications page instead of the legacy JSPs, rebased onto the epic.

Bell entries deep-link to the notices page with a query preset (outstanding / team-outstanding views).
The preset re-applies when it changes without remounting the page.
Carries the supporting notices store and service changes.

joseanesONMS · 2026-07-31T17:28:46Z

@marshallmassengill review requested — stacks on #8709 (only the top commit is new here).

joseanesONMS · 2026-08-04T11:01:23Z

@marshallmassengill @synqotik — ready for review. Since the PR was opened:

Individual bell entries now open the new page (your-outstanding preset) instead of detail.jsp.
A bell click while already on the page re-applies the preset via a route.query.preset watch (a hash-query change doesn't remount the route).
excludeNotifiedUser now marks the criteria distinct (the usersNotified LEFT_JOIN otherwise duplicated notices and inflated the count) and ignores a blank value instead of 500ing.
Dark-mode text fix for the page and its dialogs.

Lint clean, UI suite green (2451 passed), backend module builds.

Integration note: the CSV export (fetchForExport) landed on #8709 after this branch cut, so it isn't here yet. When this rebases onto the base that has it, the export call must carry excludeUser for the team preset — otherwise a team-preset export silently widens to all users.

joseanesONMS · 2026-08-04T16:37:11Z

@marshallmassengill @synqotik — dark-mode fix for the notification dialogs. PrimeVue's dialog chrome (panel/header/title) doesn't follow the dark tokens in this build, so the panel stayed white while the content and fields went dark — the earlier text-only fix then left light text on a white panel (no contrast). The notification dialog classes never land on the teleported .p-dialog root, so this targets .p-dialog directly to pin the surface dark and force the title, field labels and header icons light. Verified in a running instance across all four config dialogs.

Heads up: it's a deliberately broad .p-dialog override (with !important to beat PrimeVue's runtime-injected styles), scoped to load with the Notifications page. Happy to relocate it to a global theme file if you'd rather it live app-wide.

synqotik · 2026-08-05T13:55:55Z

Do not check in this file! These are temporary files.

synqotik · 2026-08-05T13:55:59Z

Do not check in this file! These are temporary files.

synqotik · 2026-08-05T14:01:13Z

@@ -1,42 +1,43 @@
 <template>


Use OnmsDialog, OnmsTab, etc. here.

synqotik · 2026-08-05T14:01:28Z

          <div class="general-tab">
            <div class="status-toggle">
-              <OnmsToggleSwitch
+              <PToggleSwitch


Use OnmsToggleSwitch

synqotik · 2026-08-05T14:01:56Z

    </div>

-    <OnmsTable
+    <DataTable


Use OnmsTable

synqotik · 2026-08-05T14:03:51Z

    const guarded = /^[=+\-@\t\r]/.test(value) ? `'${value}` : value
    return `"${guarded.replaceAll('"', '""')}"`
  }
  const csv = [


Use composables/useDownload here as much as possible.

synqotik · 2026-08-05T14:04:38Z

  const headers = Object.keys(rows[0])
  const escapeHtml = (value: string) =>
    value.replaceAll('&', '&amp;').replaceAll('<', '&lt;').replaceAll('>', '&gt;')
  const html = `<!DOCTYPE html>


Is there a way to make this a separate Vue component vs. inline html? We should avoid big HTML strings.

synqotik · 2026-08-05T14:05:13Z

Use OnmsIcon

synqotik · 2026-08-05T14:05:50Z

@@ -1,2 +1,2 @@
 <template>
  <TableCard class="notification-queries-bar">


Use OnmsCard

synqotik · 2026-08-05T14:06:10Z

      </div>
      <div class="query-forms">
        <div class="search-row">
          <IftaLabel>


Use OnmsInputText

synqotik · 2026-08-05T14:06:29Z

-          <OnmsIconButton
-            variant="outlined"
-            :icon="Search"
+          <Button


Use OnmsButton or OnmsIconButton

synqotik · 2026-08-05T14:09:28Z

+  issue shared with the dashboard). The `.open-dark` theme class on <html> IS
+  reliable, and teleported dialogs live under <html> too — so key explicit
+  readable colours off it for the notification page and its dialogs/tabs.
+-->


This should all be removed, don't want a bunch of custom CSS in individual files.

See if the dark mode issue goes away when you update to latest releaset-36.x or develop and use OnmsDialog, etc. If it doesn't then we should have a separate PR to fix that globally.

synqotik · 2026-08-05T14:13:39Z

@marshallmassengill @synqotik — dark-mode fix for the notification dialogs

@joseanesONMS
Try getting latest release-36.x or develop (may need to first update the target branch), then use all OnmsUI components. If there's still an issue, we should fix it in a separate PR just for that. I think the latest updates I made should fix any dark mode issues, but there still may be some. I don't want a bunch of file-specific custom CSS.

joseanesONMS · 2026-08-05T14:18:52Z

@synqotik addressed — rebased onto the current base so the whole diff is now just the bell's own work (the deep-link + teamOutstanding preset):

The two temp files are gone, and the migrated OnmsDialog/tabs/table/card come from the base now (your wrapper comments on ConfigureNotificationsDialog / NoticesTable / NotificationQueriesCard resolve against the base's versions — the only bell change left in that card is the "anyone but you" link).
Removed the inline html.open-dark / .p-dialog CSS from Notifications.vue. If any dark-mode gap remains after your latest theme updates, I'll do it as a separate global PR rather than file-specific CSS, per your note.
Also fixed a real bug I'd flagged: fetchForExport now carries excludeUser, so a teamOutstanding export stays scoped instead of silently widening to everyone.

TableCard → OnmsCard (comment on line 2) is app-wide — 14 consumers — so I'd rather do that as its own cleanup than in the bell PR. Let me know if you'd prefer otherwise.

joseanesONMS · 2026-08-07T20:31:43Z

@synqotik @marshallmassengill Ready for another look. Rebased onto the epic (now 36.0.3-SNAPSHOT on release-36.x); the notices container now also hosts the About-Notices dialog and Configure button that arrived with the shared epic changes. Build, lint and store tests are green locally; CI is running.

Deep-link the top-bar notification bell to the notices page with a query preset so the outstanding/team views open directly, re-applying the preset when it changes without remounting. Carries the supporting notices store and service changes.

joseanesONMS · 2026-08-11T19:52:36Z

@synqotik @marshallmassengill Updated and green on the latest epic. Temp files are gone and the container carries the About-Notices dialog + Configure button from the epic. The broader onms-ui wrapper suggestions (OnmsSearchInput/OnmsTabs/OnmsCard, inline-HTML extraction) are the routed-pages restructure, which lands as its own follow-up PR. combined-builds is passing.

joseanesONMS requested a review from marshallmassengill July 31, 2026 17:28

joseanesONMS force-pushed the jira/NMS-20124-bell-notifications branch from 3cca45a to 00941d5 Compare July 31, 2026 19:33

joseanesONMS requested a review from synqotik August 3, 2026 13:59

Base automatically changed from jira/NMS-20100-notifications-page to jira/NMS-20100 August 5, 2026 10:52

synqotik reviewed Aug 5, 2026

View reviewed changes

Comment thread opennms-webapp-rest/tmlog0.log Outdated

synqotik Aug 5, 2026

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not check in this file! These are temporary files.

synqotik reviewed Aug 5, 2026

View reviewed changes

Comment thread ui/src/components/AdminNotifications/NotificationExplanationsCard.vue Outdated

synqotik Aug 5, 2026

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use OnmsIcon

synqotik reviewed Aug 5, 2026

View reviewed changes

joseanesONMS force-pushed the jira/NMS-20124-bell-notifications branch from d859680 to 978f1c8 Compare August 5, 2026 14:18

joseanesONMS force-pushed the jira/NMS-20124-bell-notifications branch 2 times, most recently from 259b672 to c59c2e9 Compare August 5, 2026 14:27

joseanesONMS force-pushed the jira/NMS-20100 branch from 438cbd5 to 84d6b4b Compare August 7, 2026 18:25

joseanesONMS force-pushed the jira/NMS-20124-bell-notifications branch 2 times, most recently from 933ae39 to 60feb3a Compare August 7, 2026 20:09

joseanesONMS requested a review from synqotik August 7, 2026 20:31

joseanesONMS force-pushed the jira/NMS-20124-bell-notifications branch from 60feb3a to 4930198 Compare August 11, 2026 13:52

		@@ -1,2 +1,2 @@
		<template>
		<TableCard class="notification-queries-bar">

Uh oh!

Conversation

joseanesONMS commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joseanesONMS commented Jul 31, 2026

Uh oh!

joseanesONMS commented Aug 4, 2026

Uh oh!

joseanesONMS commented Aug 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

synqotik commented Aug 5, 2026

Uh oh!

joseanesONMS commented Aug 5, 2026

Uh oh!

joseanesONMS commented Aug 7, 2026

Uh oh!

joseanesONMS commented Aug 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joseanesONMS commented Jul 31, 2026 •

edited

Loading