NMS-20131: PrimeVue Manage Surveillance Categories page - #8729
Open
joseanesONMS wants to merge 2 commits into
Open
NMS-20131: PrimeVue Manage Surveillance Categories page#8729joseanesONMS wants to merge 2 commits into
joseanesONMS wants to merge 2 commits into
Conversation
synqotik
reviewed
Aug 4, 2026
| > | ||
| <template #header> | ||
| <span class="panel-header"> | ||
| <i class="pi pi-question-circle" aria-hidden="true" /> |
Contributor
There was a problem hiding this comment.
Make sure to merge/rebase from/onto the latest develop.
Then, use OnmsIcon or OnmsIconButton here instead of pi-question-circle.
Basically, rewrite everything to use the Onms- components instead of any direct PrimeVue components.
synqotik
reviewed
Aug 4, 2026
| <TableCard class="categories-table"> | ||
| <div class="header"> | ||
| <div class="card-title">Surveillance Categories</div> | ||
| <Button |
Contributor
There was a problem hiding this comment.
Use OnmsIconButton, OnmsTable
synqotik
reviewed
Aug 4, 2026
| @@ -0,0 +1,145 @@ | |||
| <template> | |||
| <Dialog | |||
synqotik
reviewed
Aug 4, 2026
| <Message v-if="errorText" severity="error" :closable="false" data-test="dialog-error">{{ errorText }}</Message> | ||
|
|
||
| <FormField v-if="!isEditing"> | ||
| <IftaLabel> |
Migrates the legacy surveillance-categories admin page to a PrimeVue /ui
page reusing existing REST — no backend change: category CRUD via the v1
/rest/categories service and node membership via its granular
/rest/categories/{name}/nodes/{nodeId} sub-resource. Table of categories
with create (name + description), description edit (the name is the
immutable identifier), delete, and a Manage Nodes dialog that assigns and
unassigns nodes with a PickList, applying only the diff against the
membership API. Member nodes are read with the node search that actually
filters by membership (category.name==NAME); the menu entry points at the
new page.
Replace the direct PrimeVue components (Button, DataTable, Column, Dialog, InputText, Checkbox, ToggleSwitch, IconField/InputIcon) across the four Manage Categories components with their Onms-* seam wrappers, and swap the help-panel question-circle for OnmsIcon. Message and IftaLabel stay on PrimeVue as no seam wrapper exists for them.
joseanesONMS
force-pushed
the
jira/NMS-20131-surveillance-categories
branch
from
August 4, 2026 19:44
f09a904 to
6f00327
Compare
Contributor
Author
|
@synqotik — done. Rebased onto develop and migrated all four Manage Categories components off direct PrimeVue onto the Onms-* seam wrappers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the Manage Surveillance Categories admin page to a PrimeVue /ui screen. Reuses the existing
/rest/categoriesCRUD and the granular node-membership endpoints unchanged — no backend change.MenuHeaderITis updated to assert the new page.nodeService, so it scales to large inventories) with a per-row membership toggle applied immediately.