Skip to content

M #-: Assert that fstab config matches existing filesystems (fix)#236

Open
sk4zuzu wants to merge 1 commit into
masterfrom
fstab-idempotence-guard
Open

M #-: Assert that fstab config matches existing filesystems (fix)#236
sk4zuzu wants to merge 1 commit into
masterfrom
fstab-idempotence-guard

Conversation

@sk4zuzu

@sk4zuzu sk4zuzu commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
@sk4zuzu sk4zuzu requested review from dann1, fpolanco-one and tinova June 26, 2026 15:20
@fpolanco-one

Copy link
Copy Markdown

Description:
Existing mounted datastore filesystems cannot be reformatted by one-deploy, actual code will mount the datastore mountpoint in fstab, and upon reboot, the host will be held in emergency mode because a mountpoint cannot be fulfilled due to incorrect filesystem. Example: existing FS: VFAT, specified FS: XFS.

@sk4zuzu

sk4zuzu commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

Yes, if the device is already mounted one-deploy will skip it even if force flag is provided, as we cannot mkfs on a device that is mounted and we cannot really auto-unmount as we would have to scan running processes that hold the mountpoint and kill them (we can't make that decision in general).

This PR simply adds missing (arguably) feature of the mount module, it just detects the discrepancy and gives some time to the user so the mismatch can be corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants