Skip to content

cgroups: handle the cgroup v1 release_agent race #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pva wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −3
Open

cgroups: handle the cgroup v1 release_agent race #1058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions sh/rc-cgroup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,16 +104,26 @@ cgroup_add_service()
# it prevents unwanted inheriting of the user
# cgroups. But may lead to problems where that inheriting
# is needed.
local cgroup d openrc_cgroup
local attempts cgroup d openrc_cgroup
for d in /sys/fs/cgroup/* ; do
[ -w "${d}"/tasks ] && printf "%d" 0 > "${d}"/tasks
done

openrc_cgroup=/sys/fs/cgroup/openrc
if [ -d "$openrc_cgroup" ]; then
cgroup="$openrc_cgroup/$RC_SVCNAME"
mkdir -p "$cgroup"
[ -w "$cgroup/tasks" ] && printf "%d" 0 > "$cgroup/tasks"
attempts=0
# The asynchronous release agent may remove an empty cgroup
# between creating it and writing to tasks, so retry both.
while [ "$attempts" -lt 3 ]; do
mkdir -p "$cgroup" || return 0
if [ -w "$cgroup/tasks" ] &&
{ printf "%d" 0 > "$cgroup/tasks"; } 2> /dev/null
then
return 0
fi
attempts=$((attempts+1))
done
fi
}

Expand Down
Loading