openrc: avoid converting failed PTY reads to size_t - #1059
Open
pva wants to merge 1 commit into
Open
Conversation
openrc-run and rc_logger used read()'s return value as a size_t without checking for errors. Since read() returns an ssize_t, a failure return value -1 was converted to SIZE_MAX. This path was normally hidden because the reader processes retained slave_tty, preventing the master from reporting a hangup. However, read() may still fail for other reasons, so handle its result explicitly. With this path handled, it is also safe to close the unused slave_tty descriptors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openrc-run and rc_logger used read()'s return value as a size_t without checking for errors. Since read() returns an ssize_t, a failure return value -1 was converted to SIZE_MAX.
This path was normally hidden because the reader processes retained slave_tty, preventing the master from reporting a hangup. However, read() may still fail for other reasons, so handle its result explicitly.
With this path handled, it is also safe to close the unused slave_tty descriptors.