Skip to content

front: fix TOD by passing original op reference type to track occupancy endpoint#16716

Merged
Akctarus merged 1 commit into
devfrom
tmn/front/fix-virtual-tracks-display
Jul 22, 2026
Merged

front: fix TOD by passing original op reference type to track occupancy endpoint#16716
Akctarus merged 1 commit into
devfrom
tmn/front/fix-virtual-tracks-display

Conversation

@Akctarus

@Akctarus Akctarus commented May 13, 2026

Copy link
Copy Markdown
Contributor

closes #16712

Feel like there are others issues with virtual tracks/TOD, but the main bug should be fixed with this PR

@github-actions github-actions Bot added the area:front Work on Standard OSRD Interface modules label May 13, 2026
@Akctarus
Akctarus force-pushed the tmn/front/fix-virtual-tracks-display branch 5 times, most recently from a3cd81c to de814cd Compare May 18, 2026 13:03
@Akctarus
Akctarus force-pushed the tmn/front/fix-virtual-tracks-display branch 4 times, most recently from 8b37684 to d45ab71 Compare June 22, 2026 09:53
@Akctarus Akctarus closed this Jun 24, 2026
@Akctarus
Akctarus force-pushed the tmn/front/fix-virtual-tracks-display branch from d45ab71 to 063b472 Compare June 24, 2026 13:49
@Akctarus Akctarus reopened this Jun 24, 2026
@Akctarus
Akctarus force-pushed the tmn/front/fix-virtual-tracks-display branch from 5187967 to 4556c91 Compare June 24, 2026 13:52
@Akctarus
Akctarus marked this pull request as ready for review June 24, 2026 13:52
@Akctarus
Akctarus requested a review from a team as a code owner June 24, 2026 13:52
@Akctarus
Akctarus force-pushed the tmn/front/fix-virtual-tracks-display branch from 4556c91 to ccbcc64 Compare June 24, 2026 13:59

@Caracol3 Caracol3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Just left one comment

@emersion
emersion self-requested a review June 29, 2026 15:59
@Akctarus
Akctarus requested a review from Caracol3 July 1, 2026 08:25

@SarahBellaha SarahBellaha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Comment thread front/src/applications/operationalStudies/hooks/usePathProjection.ts Outdated
@emersion
emersion self-requested a review July 1, 2026 15:07

@Caracol3 Caracol3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akctarus
Akctarus force-pushed the tmn/front/fix-virtual-tracks-display branch 2 times, most recently from 123095f to 561d829 Compare July 21, 2026 07:24
@Akctarus
Akctarus enabled auto-merge July 21, 2026 07:24
@Akctarus
Akctarus added this pull request to the merge queue Jul 21, 2026
@emersion
emersion removed this pull request from the merge queue due to a manual request Jul 21, 2026
@emersion

Copy link
Copy Markdown
Member

I've removed this PR from the merge queue because I'd like to continue the conversation started above. If I miss a comment, please do ping me!

Comment thread front/src/modules/simulationResult/types.ts Outdated

@emersion emersion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've posted some suggestions above!

@Akctarus
Akctarus requested a review from emersion July 22, 2026 09:53

@emersion emersion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, LGTM!

Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus
Akctarus force-pushed the tmn/front/fix-virtual-tracks-display branch from 098cf59 to 62dc537 Compare July 22, 2026 15:00
@Akctarus
Akctarus enabled auto-merge July 22, 2026 15:01
@Akctarus
Akctarus added this pull request to the merge queue Jul 22, 2026
Merged via the queue into dev with commit 7357050 Jul 22, 2026
33 checks passed
@Akctarus
Akctarus deleted the tmn/front/fix-virtual-tracks-display branch July 22, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:front Work on Standard OSRD Interface modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TOD : virtual track not displayed sometimes

4 participants