editoast: authz: update several tests to use the TestExtClient API - #17752
Merged
Conversation
Sh099078
force-pushed
the
lf/refacto-authz-tests
branch
from
July 20, 2026 19:25
3acb14b to
0100962
Compare
Sh099078
changed the title
Sh099078
changed the title
leovalais
approved these changes
Jul 22, 2026
leovalais
left a comment
leovalais
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure we can implement a trait in several places like regular impl blocks. We'd need a trait for each resource, but that's a bit...
- Add missing authz functions in TestExtClient API. - Use TestExtClient whenever possible in `authz` tests. Signed-off-by: Loup Federico <16464925+Sh099078@users.noreply.github.com>
Sh099078
force-pushed
the
lf/refacto-authz-tests
branch
from
July 22, 2026 13:30
0100962 to
bd98637
Compare
Contributor
Author
|
rebase on dev + squash commits |
Sh099078
enabled auto-merge
July 22, 2026 13:31
github-project-automation
Bot
moved this from Awaiting merge
to Awaiting Validation
in Board PI 21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #17242 (comment), remove boilerplate from some tests by using
TestExtClientAPI ; add more utility methods when needed in the second commit.The first commit updates
infraandrolling stockresources tests, the second generalizes it to all openfga resources in theauthzcrate. If both commits seem fine to reviewers I can squash them before mergingOn a sidenote: maybe it would be more readable to implement the
TestExtClientmethods of each resource type in the said resource type module instead of grouping them all intest_client_ext.rs? With more than two resources it starts to get messy