perbaikan foto pengurus dan media terkait tidak tampil#1621
Open
pandigresik wants to merge 2 commits into
Open
perbaikan foto pengurus dan media terkait tidak tampil#1621pandigresik wants to merge 2 commits into
pandigresik wants to merge 2 commits into
Conversation
Contributor
|
🔄 AI PR Review sedang antri di server...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix Foto Pengurus dan Media Terkait Tidak Tampil
Description
Memperbaiki bug dimana foto pengurus dan logo media terkait tidak tampil di widget perangkat desa. Penyebabnya adalah path gambar yang tidak sesuai dengan struktur penyimpanan file di server.
Changes made:
website-data.blade.php— menambahkan prefixstorage/pada path agar sesuai dengan Laravel public storagewebsite-data.blade.php— menyederhanakan logika pembuatan URL foto, langsung menggunakan path dari database tanpa tambahanasset("")/themes/*di.gitignoreagar file tema tidak diabaikan gitReason for change:
asset("media_terkait/")tanpastorage/sehingga file tidak ditemukanasset("")+item.fotoyang menghasilkan URL ganda (misal:http://domain.com/http://domain.com/storage/foto.jpg)Impact of change:
✅ Tampilan: Foto pengurus dan logo media terkait kini tampil dengan benar
✅ Kinerja: Path gambar lebih efisien tanpa URL duplikat
✅ Deployment: File tema ikut terdeploy karena tracking git diaktifkan
Related Issue
#1619 (comment)
Steps to Reproduce
Before fix (problem):
After fix (solution):
Testing on related features:
Checklist
Technical Details
Technical Explanation
Media Terkait:
asset("media_terkait/")+ data.logo → menghasilkan path tanpastorage/asset("storage/media_terkait")+ '/' + data.logo → path sesuai Laravel public storageFoto Pengurus:
item.foto.startsWith('http') ? item.foto : asset("") + item.foto→ menghasilkan double base URLitem.fototanpa manipulasi — path dari database sudah lengkapConfiguration changes
.gitignore:/themes/*di-uncomment agar folder tema tidak diabaikanDependencies added
No new dependencies
Testing
Manual Testing
Screenshots / Video
Before:
Foto dan logo tidak tampil, muncul broken image icon
After:
Foto pengurus dan logo media terkait tampil dengan benar
Breaking Changes
None
Migration Guide
Not required