Conversation
Collaborator
|
братан а вот это обязательно или не |
Collaborator
Это выглядит как то что сломает в итоге совместимостью с официальными клиентами, ведь в документации там инт насколько помню |
Contributor
Author
Пофиксил, терь должно быть правильно |
zavolo
force-pushed
the
fix/im-gethistoryattachments
branch
2 times, most recently
from
September 20, 2026 15:21
34cf02a to
3569555
Compare
Collaborator
|
int $report_id = 0 убери короче это abandoned и лучше не упоминать |
Contributor
Author
а, ок ща |
Contributor
Author
так всё правильно? |
…tHistoryAttachments The shared-attachments screen (opened from a chat user profile) issues many getHistoryAttachments calls; when the broker returned a null items list the client failed every request. Coerce items to an array and next_from to a string on the success path, matching the error-path defaults.
…rsion Booleans are required by modern clients (the VK Messenger parses them with getBoolean) but break strictly-typed older clients that decode them as integers (e.g. OpenVK iOS VKUserProfile.isClosed: Int?). Emit booleans only for API version >= 5.200 and keep integers for older versions.
zavolo
force-pushed
the
fix/im-gethistoryattachments
branch
from
September 20, 2026 15:38
3569555 to
8fe50ea
Compare
Collaborator
|
да. Ну я мержать не буду до завтра может ещё чего захочешь добавить |
Contributor
Author
я ещё пару фиксов мб сделаю седня и всё |
… getInfo
The client stores account.getInfo link_redirects into AccountInfo.linkRedirectsJson
and eagerly parses it with new JSONObject(...) at startup; a null value threw and
was reported as a caught non-fatal on every launch. Return "{}" so the parse
succeeds.
…r HTTPS Build the subscription base_url as https://<host>/queue (stripping any api. prefix) so the client long-polls the broker queue keep-alive endpoint instead of the messages /nim endpoint, keeping the queue connection alive.
zavolo
force-pushed
the
fix/im-gethistoryattachments
branch
from
September 20, 2026 16:23
94e648e to
fbcedb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1796.
The shared-attachments screen (opened from a chat user's profile in the VK Messenger client) issues many
messages.getHistoryAttachmentscalls. When the broker returned anullitems list, the client failed every request ("не удалось выполнить запрос").Coerce
itemsto an array andnext_fromto a string on the success path, matching the defaults already used on the error path.Verified live against the VK Messenger client — the shared media/attachments screen now loads.