Repository navigation
Reset video decoder fast-forward/slow-motion when the video pid is stopped - #1366
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When a DVB player (e.g. a recording played through eDVBServicePlay) is left while in fast-forward, slow-motion or trickmode, the video decoder keeps that setting. eTSMPEGDecoder::setState() only sets fast-forward and slow-motion while it starts a video pid. When it stops one, nothing resets them.
Anything that plays next without setting them itself inherits the old rate. That includes GStreamer sinks such as servicemp3 for IPTV and for recordings. After exiting an 8× fast-forward, live IPTV starts with the decoder still at 8× (VIDEO0: update_trickmode, ff=8). The result is continuous audio and video tsm fail / pts error messages and no usable playback. Playing a DVB service or a recording first clears it, because starting a video pid sets the state.
Fix:
In setState(), before the video decoder is stopped, send VIDEO_SLOWMOTION 0 and VIDEO_FAST_FORWARD 0 if the decoder state is fast-forward, trickmode or slow-motion.
Successfully tested on DM900.