Repository navigation
Various fixes - #1367
Merged
Merged
Various fixes#1367
Conversation
Contributor
|
When you use someone else's code, it's actually standard practice and courtesy to credit the original author. |
Contributor
Author
|
@jbleyel You were credited when the original eStack was added. This commit fixes the gaps since i didnt trasferred everything last time. I believe there is no problem with the eStack on your side. The problem was at our side only. |
Contributor
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the GUI stacking system, refactors HDMI color depth handling for specific devices, and removes legacy workarounds. The most important changes are grouped below:
GUI Stack System Enhancements
eStackclass: Added a destructor, improved child management, and ensured proper layout recalculation on size changes or when shown. The stack now handles transparency and spacing more robustly, and cleans up child references on destruction (lib/gui/estack.cpp,lib/gui/estack.h,lib/gui/ewidget.cpp,lib/gui/ewidget.h). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Screen.pyto properly show/hide and manage stacks, ensuring child widgets are correctly added to stacks and their layout is applied as intended (lib/python/Screens/Screen.py). [1] [2] [3] [4] [5] [6]align,spacing,stack) and improved context parsing for widget alignment and spacing (lib/python/skin.py). [1] [2] [3] [4] [5] [6] [7]HDMI Color Depth Handling
gbquad4kproandvuduo4klitedevices: Now only allows10bitand12bitoptions, sets10bitas default, and removes the old workaround that forced "12bit" for these devices. This simplifies user choices and removes device-specific hacks (lib/python/Components/AVSwitch.py,lib/python/Components/SystemInfo.py,lib/python/Screens/VideoMode.py). [1] [2] [3] [4]Removal of Legacy Workarounds
VideoJudderDriverFixTaskand all related logic, as the workaround is no longer needed for the affected devices. This cleans up unnecessary code and reduces maintenance overhead (lib/python/Components/AVSwitch.py,lib/python/Components/SystemInfo.py,lib/python/StartEnigma.py). [1] [2] [3]Build System Updates
configure.ac: Now excludesgbquad4kpro,vuduo4klite, andvuultimo4kfrom software HDR detection, making the logic more maintainable and accurate (configure.ac).These changes collectively enhance the flexibility, maintainability, and user experience of the GUI and video configuration subsystems.