Skip to content

Various fixes - #1367

Merged
TwolDE2 merged 3 commits into
OpenViX:Developerfrom
DimitarCC:eStack-fix
Oct 10, 2026
Merged

TwolDE2 merged 3 commits into
OpenViX:Developerfrom
DimitarCC:eStack-fix

Conversation

@DimitarCC

Copy link
Copy Markdown
Contributor

This pull request introduces significant improvements to the GUI stacking system, refactors HDMI color depth handling for specific devices, and removes legacy workarounds. The most important changes are grouped below:

GUI Stack System Enhancements

  • Refactored the eStack class: Added a destructor, improved child management, and ensured proper layout recalculation on size changes or when shown. The stack now handles transparency and spacing more robustly, and cleans up child references on destruction (lib/gui/estack.cpp, lib/gui/estack.h, lib/gui/ewidget.cpp, lib/gui/ewidget.h). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
  • Updated Screen.py to properly show/hide and manage stacks, ensuring child widgets are correctly added to stacks and their layout is applied as intended (lib/python/Screens/Screen.py). [1] [2] [3] [4] [5] [6]
  • Improved skinning support for stack widgets: Added new skin attributes (align, spacing, stack) and improved context parsing for widget alignment and spacing (lib/python/skin.py). [1] [2] [3] [4] [5] [6] [7]

HDMI Color Depth Handling

  • Refactored HDMI color depth configuration for gbquad4kpro and vuduo4klite devices: Now only allows 10bit and 12bit options, sets 10bit as default, and removes the old workaround that forced "12bit" for these devices. This simplifies user choices and removes device-specific hacks (lib/python/Components/AVSwitch.py, lib/python/Components/SystemInfo.py, lib/python/Screens/VideoMode.py). [1] [2] [3] [4]

Removal of Legacy Workarounds

  • Removed the VideoJudderDriverFixTask and all related logic, as the workaround is no longer needed for the affected devices. This cleans up unnecessary code and reduces maintenance overhead (lib/python/Components/AVSwitch.py, lib/python/Components/SystemInfo.py, lib/python/StartEnigma.py). [1] [2] [3]

Build System Updates

  • Improved software HDR detection logic in configure.ac: Now excludes gbquad4kpro, vuduo4klite, and vuultimo4k from software HDR detection, making the logic more maintainable and accurate (configure.ac).

These changes collectively enhance the flexibility, maintainability, and user experience of the GUI and video configuration subsystems.

@TwolDE2
TwolDE2 merged commit 1d3f392 into OpenViX:Developer Oct 10, 2026
1 check passed
@jbleyel

jbleyel commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

When you use someone else's code, it's actually standard practice and courtesy to credit the original author.
And if you modify the code because it contains an error, you should actually report that change to the original authors.

@DimitarCC

DimitarCC commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor Author

@jbleyel You were credited when the original eStack was added. This commit fixes the gaps since i didnt trasferred everything last time. I believe there is no problem with the eStack on your side. The problem was at our side only.

@jbleyel

jbleyel commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@jbleyel You were credited when the original eStack was added. This commit fixes the gaps since i didnt trasferred everything last time. I believe there is no problem with the eStack on your side. The problem was at our side only.

Thanks

@DimitarCC
DimitarCC deleted the eStack-fix branch October 11, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants