Repository navigation
Refactor gWebOverlay to improve socket binding and healing logic - #1377
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the socket handling in the
gWebOverlayclass to make it more robust against socket file removal or replacement, and to ensure the overlay can recover automatically if the socket becomes unavailable. The main changes include extracting the socket binding logic into a new method, adding a healing mechanism to monitor and rebind the socket if necessary, and tracking the socket's inode for safe cleanup.Socket robustness and healing:
startListeninginto a newbindSocketmethod, improving code clarity and reuse. (gweb_overlay.cpp,gweb_overlay.h) [1] [2]onHealmethod and a periodiceTimer(m_heal) that checks if the socket file has been removed or replaced, and automatically rebinds the socket if needed to maintain connectivity. (gweb_overlay.cpp,gweb_overlay.h) [1] [2] [3]m_sock_inoto track the inode of the socket file, ensuring that only the correct socket file is unlinked during cleanup and preventing accidental removal if another process has rebound the same path. (gweb_overlay.cpp,gweb_overlay.h) [1] [2]These changes make the overlay's socket communication more resilient to external disruptions and improve maintainability.