Add virtual environment for python libraries, update dependency installation command to include requests library#274
Open
asiffarhankhan wants to merge 2 commits into
Open
Conversation
…llation command to include requests library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the things I had noticed while working on the hosting a flask server was that sometimes there could be a conflict due to the existing dependencies installed in the system, for this reason I have introduced a closed virtual environment which will help avoid any such conflicts.
Secondly the dependencies also required requests library to be installed which was not instructed on the readme file
Please let me know if you'd like two separate pull request in case you are only looking to merge only one of the two changes I have made.
@OvidijusParsiunas I have made a typo in my last PR so I decided to make fresh one, This is my first ever open source contribution Sorry if I am missing out on any unspoken rule of open source contribution
Thanks you!
love the work