Repository navigation
Calendar: Rework the calendar views and the top of Home - #25
Merged
Merged
Conversation
The big date header already says where you are, and the title made the top of Home and Calendar busy. The row keeps the menu button, and the title stays as a heading for TalkBack. Assisted-By: LLM Signed-off-by: Shivansh Pandey <shivanshp987@gmail.com>
Cards take a wash of the event colour with an inset colour bar, the title in a lighter (dark theme) or darker (light theme) shade of it, and location and time on their own lines with icons. Hour labels read "7 PM" with a smaller AM/PM, right-aligned against the hour lines, and all-day events get the same tint. Assisted-By: LLM Signed-off-by: Shivansh Pandey <shivanshp987@gmail.com>
Plain dates under single-letter weekdays with a hairline between weeks, instead of tiles and weekday chips. Today sits in a filled circle, the selected day in a light one, Sundays are dimmed, and each day with events gets a short bar split into the colours of up to six events. Assisted-By: LLM Signed-off-by: Shivansh Pandey <shivanshp987@gmail.com>
Twelve months in three columns with bold month names, the current one in the accent colour, and plain dates without tiles or busy shading. Today sits in a filled circle and Sundays are dimmed, so the year reads at a glance; tapping a month still opens it. Assisted-By: LLM Signed-off-by: Shivansh Pandey <shivanshp987@gmail.com>
Week showed the week's dates over one day's timeline, which made it Day with a strip. It now lays the whole week out: weekday letters over the dates above seven columns, hour labels down the side and thin lines between hours and days. Events sit in their day's column in their calendar's tint, overlapping ones side by side, and each day's first all-day event sits above the grid with a +N for the rest. Today's date is circled and its column gets the now line. Tapping a date opens that day, tapping an empty slot creates an event there, and swiping changes week. Assisted-By: LLM Signed-off-by: Shivansh Pandey <shivanshp987@gmail.com>
Pulling Home's upcoming events down asks every account to sync its calendars, like the Sync button did, and the button goes so the greeting has the width. The indicator stays while any account's calendar sync is active or pending, for up to 30 seconds, which needs READ_SYNC_STATS (a normal permission). The Sync strings and icon are no longer used. Assisted-By: LLM Signed-off-by: Shivansh Pandey <shivanshp987@gmail.com>
The heading no longer scrolls away with the events: it stays at the top of the sheet on a flat frosted strip (a light blur and the sheet colour, no glass edge), so the cards soften as they pass under it. The list is the strip's backdrop and starts below it, and the pull-to-sync indicator comes out from under the heading. Assisted-By: LLM Signed-off-by: Shivansh Pandey <shivanshp987@gmail.com>
Week gets the same navigator as Day, Month and Year above its grid,
labelled with the week of the year ("Week 46") by the first day of the
week from the settings: the arrows go to the previous and next week and
the label goes back to today.
Assisted-By: LLM
Signed-off-by: Shivansh Pandey <shivanshp987@gmail.com>
The date header followed the selected day in Calendar, so stepping to another week, month or year changed it too; the navigators already say where you are. It now always shows today, and "+ Add" still creates on the selected day in Calendar. Assisted-By: LLM Signed-off-by: Shivansh Pandey <shivanshp987@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the calendar views and the top of Home, keeping the PVOT layout (date header, Day/Week/Month/Year control, sheet, floating bar) and borrowing the clearer parts of the iOS and Google calendars.
Calendar
Home
READ_SYNC_STATS, a normal permission.pvotGlasswithout the lens) while the cards scroll under it.Sundays are dimmed in the week, month and year. The week's dates over one day's timeline came from the mockups; this follows a design review that asked for the whole week.
Tested on a DM-B50104 (Android 15): Week (above), Day, Year and the Home title on the phone, Day and Year on a build that also has #23 and #24. Month, pull-to-sync and the pinned heading have not been looked at on a phone yet; screenshots of them will follow. 280 unit tests pass.