Update gradle to 9.6.1#392
Conversation
|
Also your gradle bump will cause the build to fail due to plugin verification being enabled by default starting around gradle 9.4.0 and you have forgotten to bump the minimum required version of Gradle for PW to 9.5.0, meaning users could use older versions and get broken behaviour |
The minimum version should be changed inside utils.kt in buildSrc, and you should temporarily disable plugin verification as per gradle docs if you do bump the version used to build PW too (i’d avoid that) |
I've already taken care of these issues，and the ci could successfully pass all the test now |
|
Slapping PathSensitivity.RELATIVE and marking all things as @Cacheable isnt the correct solution, and all those other changes to build scripts and classes are fully unnecessary |
| return emptyMergeResult as MergeResult<T?> | ||
| } | ||
|
|
||
| inline fun <reified T : Task> TaskContainer.registering(noinline configuration: T.() -> Unit) = registering(T::class, configuration) |
There was a problem hiding this comment.
because of the warning of below
'fun <T : Any, C : PolymorphicDomainObjectContainer, U : T> C.registering(type: KClass): RegisteringDomainObjectDelegateProviderWithType<out C, U>' is deprecated. Use 'val element = register(name)' instead. See the Gradle 9.6 upgrading guide.
There was a problem hiding this comment.
Weird decision for them to make but gotcha
|
I would leave these changes to the maintainers and just revert the Gradle bump to paperweight build altogether or disable the plugin verification. It seems you don’t have a good idea on how PW functions internally with no offense. |
2 participants
Gradle 9.5 break a function when a new instance was called in
runNestedRootBuildsince they update the signature of method , see gradle