Skip to content

change google to debian, add docker-compose file - #6

Open
albjeremias wants to merge 3 commits into
Parkour-Vienna:masterfrom
albjeremias:master
Open

change google to debian, add docker-compose file#6
albjeremias wants to merge 3 commits into
Parkour-Vienna:masterfrom
albjeremias:master

Conversation

@albjeremias

Copy link
Copy Markdown

yellow! :)

@theSuess

theSuess commented Jul 5, 2021

Copy link
Copy Markdown
Member

Hey there, thanks for the PR.

What's the advantage of using the debian image instead of the distroless one?

@albjeremias

Copy link
Copy Markdown
Author

Well is just that I don't trust google at all to control any of the circuits i am. The only advantage is that for now.
But maybe the more sense would be to use the official go image?
https://hub.docker.com/_/golang/

anywayz.. my fight against google is political also.. check out: https://wiki.fuckoffgoogle.de

@theSuess

theSuess commented Jul 5, 2021

Copy link
Copy Markdown
Member

If you want to swap the image for something non-google I'd go with either redhat ubi or just FROM scratch. Distrust does not need any external libraries so this should not be an issue.

@albjeremias

Copy link
Copy Markdown
Author

why no golang? its probably the leightest... even though i dont have big concerns with any of those. but just to keep it simple.

@theSuess

theSuess commented Jul 6, 2021

Copy link
Copy Markdown
Member

The golang image contains the entire go toolchain. We do not have any runtime dependencies, so we can just skip this

Comment thread README.md

Up and running: `docker-compose up`

Generate a new key: `docker-compose exec distrust ./distrust genkey`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Generate a new key: `docker-compose exec distrust ./distrust genkey`
Generate a new key: `docker-compose exec distrust genkey`

We already have ENTRYPOINT ["/distrust"] in Dockerfile, so the container itself is a "distrust" and we should call it directly, like this:

# docker run -it --rm ghcr.io/parkour-vienna/distrust:master genkey
-----BEGIN RSA PRIVATE KEY-----
...

Ref: https://docs.docker.com/reference/dockerfile/#entrypoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants