Repository navigation
feat: add optional transition support to filter payloads - #50
Merged
Merged
Conversation
Akinori107
commented
Aug 26, 2026
Akinori107
commented
Collaborator
- add optional transition param (dict, e.g. durationMs=1500) to Equalizer, Timescale, Karaoke, Tremolo, Vibrato, Rotation, ChannelMix, Distortion, LowPass, Echo, Chorus, Compressor, Highpass, Phaser and Spatial
- add Filter._build() to construct self.payload and cut duplicated code across filter classes
- fix LowPass applying transition only to the lowpass key and not lowPass, both now receive the same settings dict
- transition lives on the Filter base, so update()/reset() handle it like any other param
- eq now compares transition too, so a transition-only edit is correctly detected as a change
- default behavior unchanged when transition is omitted
- document the transition parameter in docs/hdi/filters.md
- add optional transition param (dict, e.g. durationMs=1500) to Equalizer, Timescale, Karaoke, Tremolo, Vibrato, Rotation, ChannelMix, Distortion, LowPass, Echo, Chorus, Compressor, Highpass, Phaser and Spatial - add Filter._build() to construct self.payload and cut duplicated code across filter classes - fix LowPass applying transition only to the lowpass key and not lowPass, both now receive the same settings dict - transition lives on the Filter base, so update()/reset() handle it like any other param - __eq__ now compares transition too, so a transition-only edit is correctly detected as a change - default behavior unchanged when transition is omitted - document the transition parameter in docs/hdi/filters.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.