Skip to content

feat: add SponsorBlock support for NodeLink - #51

Merged
ParrotXray merged 1 commit into
ParrotXray:mainfrom
Akinori107:feat/sponsorblock-nodelink
Aug 28, 2026
Merged

ParrotXray merged 1 commit into
ParrotXray:mainfrom
Akinori107:feat/sponsorblock-nodelink

Conversation

@Akinori107

Copy link
Copy Markdown
Collaborator
  • add Player.get_sponsorblock()/set_sponsorblock()/set_sponsorblock_segments()/clear_sponsorblock(), wraps NodeLink's sponsorblock endpoint, raises NodelinkExclusive on plain Lavalink nodes
  • add Player._require_nodelink() helper to avoid duplicating the is_nodelink+version guard clause. also applied to stop(gapless=...) and play(gapless=...), which had the same duplicated is_nodelink check
  • add SponsorBlockSegmentsLoadedEvent/SponsorBlockSegmentSkippedEvent, matching NodeLink's gateway event names
  • document in docs/hdi/player.md and docs/hdi/events.md

skipMarginMs won't take effect (set_sponsorblock) until this PR is merged

- add Player.get_sponsorblock()/set_sponsorblock()/set_sponsorblock_segments()/clear_sponsorblock(), wraps NodeLink's sponsorblock endpoint, raises NodelinkExclusive on plain Lavalink nodes
- add Player._require_nodelink() helper to avoid duplicating the is_nodelink+version guard clause. also applied to stop(gapless=...) and play(gapless=...), which had the same duplicated is_nodelink check
- add SponsorBlockSegmentsLoadedEvent/SponsorBlockSegmentSkippedEvent, matching NodeLink's gateway event names
- document in docs/hdi/player.md and docs/hdi/events.md
@Akinori107
Akinori107 requested a review from ParrotXray August 28, 2026 04:26

@ParrotXray ParrotXray left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i ve reviwed thx

@ParrotXray
ParrotXray merged commit 51797c1 into ParrotXray:main Aug 28, 2026
9 checks passed
@Akinori107
Akinori107 deleted the feat/sponsorblock-nodelink branch August 28, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants