Repository navigation
Add avoidance and intrusion number computation #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
schroedtert
wants to merge
31
commits into
main
Choose a base branch
from
avoidance-intrusion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+600
−5
Open
Changes from 30 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
96fe39b
Add intrusion computation
schroedtert 3de4359
Add avoidance computation
schroedtert 3913f39
Show new functions in API reference
schroedtert d0d2888
Fix stuff
schroedtert 09d404c
Fix stuff
schroedtert 7f8a850
What's going on here?
schroedtert d11587f
Fix operator precedence bug in v_rel computation
chraibi 5da45ee
Fix cos_alpha computation in TTC formula
chraibi a8009d6
Add neighbor cutoff r_ij <= 3*r_soc to intrusion computation
chraibi a74b582
Rename foo_calculator to dimensionless_number_calculator
chraibi 76d89f2
Add docstrings for intrusion and avoidance functions
chraibi 1b4f219
Add tests for intrusion and avoidance computation
chraibi 2e990de
Add Intrusion and Avoidance section to user guide
chraibi c230d56
Apply ruff formatting to dimensionless number calculator and tests
chraibi 64b03eb
Import pandas as pd per project convention (ICN001)
chraibi 85199c4
Use .merge() method instead of pd.merge() function (PD015)
chraibi 0cde8d4
Apply ruff formatting to user guide notebook
chraibi fa0729c
formating hell
chraibi ea16ebf
Address PR #279 review feedback
chraibi 6bf6cda
Fix avoidance radius default and export column constants
chraibi da39e5a
Merge remote-tracking branch 'origin/main' into avoidance-intrusion
chraibi ccf4eab
spatial_analysis: absorb intrusion and avoidance
chraibi f301e89
spatial_analysis: avoidance contact distance is 0.2 m
chraibi 5f08264
Cap per-pair intrusion and avoidance terms
chraibi 5b4bcc0
Return every pedestrian in intrusion and avoidance
chraibi 8bc601b
Document where intrusion and avoidance differ from the paper
chraibi 7ec5d93
Follow the paper's processing in the user guide
chraibi ce3727c
Test contact, near-miss and isolated cases
chraibi f7681ad
Treat overlapping discs as no collision in avoidance
chraibi bea0deb
Cite the SI for the MAX intrusion variant
chraibi d271ce8
Note the authors' code conventions in the docstrings
chraibi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The authors report that the delineation of regimes is robust under this change."
Under which change? Does this mean when using the Max method?
Also, what does “robust” mean here? Does it mean that the separation between regimes is clearer? If so, why is the Max method not the default method?
It would be a nice addition to have a concrete example of this change.