feat(structured-ingestion-mongodb) DBI-1096: Structured ingestion settings through table mappings with validation - #4818
Open
pfcoperez wants to merge 2 commits into
Conversation
…h validation Add `structured_ingestion` and `drop_unexpected_values` to TableMapping and QRepConfig, and thread them from the mirror configuration down to the connectors: through NameAndExclude for CDC pulls, and through the QRep and snapshot workflows for the initial load and standalone QRep mirrors. Mirror validation gains the structured ingestion rules, factored into the `structured` package so CDC and QRep creation share them: only supported source peers (MongoDB for now), at least one column, and every column declaring a valid destination type, as the mapping carries the destination schema itself. The existing custom column type check moves to the same package. Nothing acts on the settings yet: the connectors keep landing documents as JSON. The e2e tests cover typed mappings passing through and the validation errors. NOTE: This is a split up from a feature branch (#4774) where all pieces are integrated.
Contributor
❌ Test FailureAnalysis: The newly added TestGetTablesStructuredIngestionSupported subtest fails deterministically in all three matrix legs for all four API suites (with a concrete expected:false/actual:true mismatch at flow/e2e/api_test.go:1252), and the test does not exist on main, so it is a real bug in PR #4818 rather than flakiness. |
…erDB level UI to set-up structured ingestion schemas manually.
pfcoperez
force-pushed
the
DBI-91/connectors/mongodb/structured-ingestion/3-mapping-settings
branch
from
September 18, 2026 11:33
c9a806e to
2c153f3
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
structured_ingestionanddrop_unexpected_valuesto TableMapping and QRepConfig, and thread them from the mirror configuration down to the connectors: through NameAndExclude for CDC pulls, and through the QRep and snapshot workflows for the initial load and standalone QRep mirrors.Mirror validation gains the structured ingestion rules, factored into the
structuredpackage so CDC and QRep creation share them.Nothing acts on the settings yet: the connectors keep landing documents as JSON. The e2e tests cover typed mappings passing through and the validation errors.
On top of the contract, PeerDB API and UI have been expanded be compatible with the structured ingestion mappings. The UI changes are not visible uless the
PEERDB_UI_STRUCTURED_INGESTION_ENABLEDdynamic setting is set totrue:The dynamic setting will be set to
truedefault once the flattening logic is merged.UI changes are isolated in the second commit of this PR.
NOTE: This is a split up from a feature branch (#4774) where all pieces are integrated.
Part of: https://linear.app/clickhouse/issue/DBI-1096