Upgrade vibrional hamiltonian docs - #6918
Merged
Merged
Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
DSGuala
self-requested a review
February 4, 2025 18:47
soranjh
commented
Jun 17, 2025
soranjh
commented
Jun 17, 2025
soranjh
commented
Jun 17, 2025
DSGuala
approved these changes
Jun 17, 2025
DSGuala
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Left several suggestions about typos or small edits. Good to merge from my side once comments are addressed 🙂
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
soranjh
commented
Jun 18, 2025
iloaiza
reviewed
Jun 19, 2025
iloaiza
approved these changes
Jun 19, 2025
iloaiza
left a comment
There was a problem hiding this comment.
Looking great! Good to go from my side
soranjh
added this pull request to the merge queue
Jun 20, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 20, 2025
soranjh
added this pull request to the merge queue
Jun 20, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 20, 2025
soranjh
added this pull request to the merge queue
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: