Per 10309 add pagination to list endpoints#802
Merged
Conversation
liam-lloyd
force-pushed
the
per-10309_add_pagination_to_list_endpoints
branch
from
July 9, 2026 20:47
4234c82 to
897dac7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
==========================================
+ Coverage 98.22% 98.30% +0.08%
==========================================
Files 93 93
Lines 2364 2482 +118
Branches 438 462 +24
==========================================
+ Hits 2322 2440 +118
Misses 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cecilia-donnelly
approved these changes
Jul 17, 2026
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
Member
There was a problem hiding this comment.
This looks good to me! Thanks @liam-lloyd .
Our API design standard says that when endpoints return multiple objects, the results should be paginated. This commit updates the GET /records endpoint to make it compliant with that standard. It leaves current behavior in place for the deprecated GET /record path, because clients are actively using this path. Once clients switch to the now-paginated GET /records, we can remove the GET /record path.
Our API design standard says that when endpoints return multiple objects, the results should be paginated. This commit updates the GET /folders endpoint to make it compliant with that standard. It leaves current behavior in place for the deprecated GET /folder path, because clients are actively using this path. Once clients switch to the now-paginated GET /folders, we can remove the GET /folder path.
Our API design principles say that endpoints that return lists of objects should paginate those lists. Currently, GET /archives/:archiveId/folders/shared returns an unpaginated response. This commit paginates it. No client currently uses this endpoint, so this should be a safe change to make.
Our API design principles say that endpoints that return lists of objects should be paginated. This commit updates GET /share-links to comply with that. Unlike other paginated endpoints, makes pageSize optional for backward compatibility. pageSize defaults to 10, which is greater than the number of share links requested in any existing call to this endpoint.
liam-lloyd
force-pushed
the
per-10309_add_pagination_to_list_endpoints
branch
from
July 17, 2026 20:08
897dac7 to
24c0a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is built on top of #801, which fixes some smaller API standard violations. Only the commits adding pagination to various endpoints are unique to this PR.