[PER-10633] Replace hardcoded colors in global styles and generic presentational component's styles#1084
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
+ Coverage 51.60% 51.68% +0.08%
==========================================
Files 354 354
Lines 12067 12067
Branches 2172 2172
==========================================
+ Hits 6227 6237 +10
+ Misses 5613 5601 -12
- Partials 227 229 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aasandei-vsp
changed the title
aasandei-vsp
force-pushed
the
PER-10633-replace-hardcoded-colors
branch
from
July 13, 2026 09:18
893dcde to
2d2a2e7
Compare
cecilia-donnelly
approved these changes
Jul 17, 2026
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
Member
There was a problem hiding this comment.
Thank you @aasandei-vsp !
Swap the legacy $PR-blue variable for the palette-scale $PR-blue-900 (same #131b4a value) across the shared style partials: loaders, profile gradient, timeline, and ui. No visual change. Issue: PER-10633
Replace raw hex, named (white/black), and rgba() color literals with the shared palette variables across the generic presentational components' styles. Add @import 'colors' where the palette wasn't already in scope. Values are unchanged, so there is no visual difference. Issue: PER-10633
aasandei-vsp
force-pushed
the
PER-10633-replace-hardcoded-colors
branch
from
July 20, 2026 11:16
2d2a2e7 to
8b19715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only replaces hardcoded colors in global styles and generic presentational components with variables that have identical values, so no visible change.
What I did do was visually check the app where the hardcoded colors have been replaced by variables.
It is tedious and I do not believe it needs to be done multiple times.
No QA needed.