[PER-10633] Replace hardcoded colors for file-browser components and generic elements from the same main screen#1085
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 52.07% 52.12% +0.04%
==========================================
Files 354 354
Lines 12085 12085
Branches 2181 2181
==========================================
+ Hits 6293 6299 +6
+ Misses 5566 5561 -5
+ Partials 226 225 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aasandei-vsp
force-pushed
the
PER-10633-replace-hardcoded-colors-v2
branch
from
July 13, 2026 09:45
462175f to
faba4e9
Compare
aasandei-vsp
changed the base branch from
PER-10633-replace-hardcoded-colors
to
main
July 13, 2026 10:30
aasandei-vsp
changed the base branch from
main
to
PER-10633-replace-hardcoded-colors
July 13, 2026 10:32
| background-color: $PR-brand-white; | ||
| border-radius: 0.3rem; | ||
| box-shadow: 0 0.5rem 1rem #0000004d; | ||
| box-shadow: 0 0.5rem 1rem rgba($PR-brand-black, 0.3); |
Member
There was a problem hiding this comment.
This is new to me! Thanks.
cecilia-donnelly
approved these changes
Jul 17, 2026
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
Member
There was a problem hiding this comment.
Officially approving, oops.
aasandei-vsp
force-pushed
the
PER-10633-replace-hardcoded-colors
branch
from
July 20, 2026 11:16
2d2a2e7 to
8b19715
Compare
Replace hard-coded color literals with the shared palette tokens across the file-browser and core/nav component styles: $PR-blue (legacy) -> $PR-blue-900, $white/white -> $PR-brand-white, #000/$black -> $PR-brand-black (including rgba(0,0,0,...) shadows -> rgba($PR-brand-black, ...)), and rgba(100,100,100,1) -> rgba($gray-dark, 1). Values are unchanged, so there is no visual difference. Issue: PER-10633
aasandei-vsp
force-pushed
the
PER-10633-replace-hardcoded-colors-v2
branch
from
July 20, 2026 11:25
faba4e9 to
ce9c8c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only replaces hardcoded colors for file-browser components and generic elements from the same main screen with variables that have identical values, so no visible change.
What I did do was visually check the app where the hardcoded colors have been replaced by variables.
It is tedious and I do not believe it needs to be done multiple times.
No QA needed.