[PR-10633]Use palette variables in auth and onboarding component styles#1086
Open
aasandei-vsp wants to merge 1 commit into
Open
Conversation
Replace hard-coded color literals with the shared palette tokens across the auth and onboarding/glam component styles: white -> $PR-brand-white, grays -> $gray-light/$gray-dark, $PR-blue -> $PR-blue-900, plus $PR-blue-50/200/400 and $PR-brand-purple/$PR-brand-yellow. Add @import 'colors' to the files that didn't already have the palette in scope. Values are unchanged, so there is no visual difference. Issue: PER-10633
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## PER-10633-replace-hardcoded-colors-v2 #1086 +/- ##
=========================================================================
- Coverage 51.72% 51.69% -0.04%
=========================================================================
Files 354 354
Lines 12067 12067
Branches 2172 2172
=========================================================================
- Hits 6242 6238 -4
- Misses 5599 5602 +3
- Partials 226 227 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only replaces hardcoded colors for auth and onboarding components with variables that have identical values, so no visible change.
What I did do was visually check the app where the hardcoded colors have been replaced by variables.
It is tedious and I do not believe it needs to be done multiple times.
No QA needed.