Skip to content

[PER-10476] Migrate refreshCurrentFolder and remove navigateLean#1091

Draft
aasandei-vsp wants to merge 1 commit into
PER-10476-replace-navigate-lean-v3from
PER-10476-replace-navigate-lean-v4
Draft

[PER-10476] Migrate refreshCurrentFolder and remove navigateLean#1091
aasandei-vsp wants to merge 1 commit into
PER-10476-replace-navigate-lean-v3from
PER-10476-replace-navigate-lean-v4

Conversation

@aasandei-vsp

@aasandei-vsp aasandei-vsp commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Issue: PER-10476
Subtask: https://permanent.atlassian.net/browse/PER-10680

Do not merge before #1090

Manual test cases — refreshCurrentFolder migration and navigateLean removal

Setup: log in on an archive with a folder containing several items.
EXPECTED: this PR affects the folder refresh that runs after content operations, and removes the last usage of the v1 /folder/navigateLean endpoint.


Folder refresh after content operations

  1. Upload a file into a folder.
    • EXPECTED: The listing refreshes and shows the new file without a manual reload.
  2. Rename an item in the folder.
    • EXPECTED: The new name appears after the refresh.
  3. Move an item to another folder, then move it back.
    • EXPECTED: The listing updates correctly after each move.
  4. Delete an item.
    • EXPECTED: The item disappears from the listing.
  5. Change the sort order of the folder.
    • EXPECTED: The list re-sorts, and the order persists after navigating away and back.

Refresh failure handling

  1. With the folder open, go offline (DevTools > Network > Offline) and upload/rename an item, then go back online.
    • EXPECTED: An error is surfaced or the operation fails gracefully — no blank listing, no unhandled errors in the console.

Endpoint removal

  1. With the DevTools Network tab open, browse folders, refresh contents (upload/rename), open shares, and use the publish dialog.
    • EXPECTED: No request to /folder/navigateLean is made anywhere in the app.

Move DataService.refreshCurrentFolder to getWithChildren and delete
the now-unused navigateLean endpoint method from FolderRepo.

Issue: PER-10476
@aasandei-vsp
aasandei-vsp marked this pull request as draft July 16, 2026 12:25
@aasandei-vsp aasandei-vsp self-assigned this Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.23%. Comparing base (578d1b8) to head (a5815a0).

Files with missing lines Patch % Lines
src/app/shared/services/data/data.service.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           PER-10476-replace-navigate-lean-v3    #1091      +/-   ##
======================================================================
- Coverage                               52.32%   52.23%   -0.09%     
======================================================================
  Files                                     355      355              
  Lines                                   12133    12131       -2     
  Branches                                 2191     2191              
======================================================================
- Hits                                     6348     6337      -11     
- Misses                                   5559     5566       +7     
- Partials                                  226      228       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant