Repository navigation
Conversation
This translate to a substential reduction in constructor call costs as the body no longer needs to always re-capture (and re-hash/clone) the entire context. This can save substential performance.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broadly this does the following:
.with(...)calls with anonymous closures, allowing their captured environments to benefit from cached hashing while preserving their printed representations.Performance
Codly’s
many-smallworkload: 120 independent seven-line Rust blocks.This is a 40.7% reduction in compile time for this workload.
This should pass the entire CI suite, although I have only tested v0.15.1 so far so we need to see if the CI passes.
Disclaimer
Generative AI was used in the making of the original code: it found the optimization potential and I implemented part of the changes, with other parts being done directly by genAI.