Prevent PI0/PI05 JAX to PyTorch weight precision drift.#978
Open
Greyman-Seu wants to merge 2 commits into
Open
Prevent PI0/PI05 JAX to PyTorch weight precision drift.#978Greyman-Seu wants to merge 2 commits into
Greyman-Seu wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a small safeguard to the JAX-to-PyTorch checkpoint conversion path for PI0-family models, including PI0 and PI05.
During conversion, the model config dtype is forced to
float32internally if the source config uses another dtype. This avoids accidental precision loss in the intermediate PyTorch checkpoint and helps keep JAX and PyTorch weightsnumerically aligned.
Motivation
During OpenPI inference acceleration work, we need the following path to stay numerically aligned: