Repository navigation
fix(portal): land on Overview after connecting, not Feature requests - #21
Merged
Merged
Conversation
added 2 commits
September 8, 2026 21:41
The #connect= token flow routed a newly-signed-in participant straight to /requests. Reported from the PicPeak admin side: the "Open usage portal" button is meant to show what's being used across installations, and users expect that landing page to be the Overview, not the feature-request list.
Redirecting to Overview after #connect= (previous commit) silently dropped the "You are connected for voting." confirmation, since it only rendered on the Requests page. Render it on Overview whenever a voting session is active, and update the two e2e tests that assumed connecting landed directly on Requests with a ready-to-click vote button. Found by CI (required e2e checks) after the previous commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reported from the PicPeak admin side: clicking "Open usage portal" (which mints a
#connect=session token) landed on/requestsinstead of/— the Overview page. An admin checking what's being used across installations expects that button to open the overview, not the feature-request list.Since
/is already labelednavOverviewin the nav, this is a one-line fix: route there instead of/requestsafter a successful connect.Type of change
How Has This Been Tested?
tsc --noEmit: clean.npm test: same 50 passed / 27 failed as onmainbefore this change (confirmed viagit stash+ rerun) — the failures are pre-existing (server/weeklyReporter.jsmodule resolution in this worktree, unrelated toweb/main.tsx), not caused by this change.#connect=browser tests insecurity.spec.tscheck the "connected" message and manually navigate afterward), so nothing needed updating there.test:e2e) wasn't run directly — verification here istsc+ the unit suite + manual reasoning about the two-line diff's blast radius.Checklist