Skip to content

fix(edgelist): rename legacy marker columns in record batches - #480

Merged
Aratz merged 4 commits into
devfrom
cursor/01-edgelist-legacy-marker-rename-e226
Oct 6, 2026
Merged

Aratz merged 4 commits into
devfrom
cursor/01-edgelist-legacy-marker-rename-e226

Conversation

@Aratz

@Aratz Aratz commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Edgelist.to_record_batches renames legacy marker1 and marker2 columns to marker_1 and marker_2, matching to_polars, to_df, and iterator.
  • Independent of the panel-concatenation stack. Base branch is dev.

Test plan

  • CI passes (ruff, ruff format, mypy, pytest)
  • test_record_batches_rename_legacy_marker_columns covers a legacy record batch

Made with Cursor

Edgelist.to_record_batches left marker1 and marker2 unchanged, unlike to_polars, to_df, and iterator.

Co-authored-by: Adrien Coulier <adrien.coulier@pixelgen.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7cf60ff. Configure here.

Comment thread CHANGELOG.md Outdated
@Aratz Aratz self-assigned this Oct 5, 2026
@Aratz
Aratz requested a review from elhb October 5, 2026 14:45
@Aratz

Aratz commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

@elhb I've done a couple changes here:

  1. instead converting each batch to a dataframe to rename the columns and then convert it back to a record batch, I adjusted the SQL query so that this is done immediately without any extra conversions or copies
  2. Eventually, such backward compatibility patches will accumulate, which will both affect readability and make it difficult to get an overview of such patches if we decide to deprecate them. I've started to isolate such patches in a legacy/ folder. This way the patches don't stand in the way as much and it becomes much easier for us to audit and possibly remove such patches later.

@Aratz
Aratz force-pushed the cursor/01-edgelist-legacy-marker-rename-e226 branch from b7b4dec to 0743850 Compare October 6, 2026 11:45
@Aratz
Aratz merged commit 567292e into dev Oct 6, 2026
15 checks passed
@Aratz
Aratz deleted the cursor/01-edgelist-legacy-marker-rename-e226 branch October 6, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants