Repository navigation
Conversation
Aratz
added this pull request to stack #490
October 6, 2026 12:13
Base automatically changed from
cursor/02-hashing-marker-id-helpers-e226
to
pna-3624_combined_panels
October 6, 2026 13:52
A PNAAntibodyPanel now records the panel files that contributed its markers. Metadata properties are only defined for a single source. Panels can be concatenated, split per source, and compared independently of source order. Co-authored-by: Adrien Coulier <adrien.coulier@pixelgen.com>
Aratz
force-pushed
the
cursor/03-panel-sources-concatenate-e226
branch
from
October 6, 2026 14:02
bf13818 to
2f8d6d5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 21b32de. Configure here.
| source_ids.astype("int64"), | ||
| file_name=self.filename if single_source else None, | ||
| filepath=self.filepath if single_source else None, | ||
| ) |
There was a problem hiding this comment.
Negative source index mishandles markers
Low Severity
replace_source and source_as_panel use the same integer as a Python list index and as a marker_source_ids value. Negative indexes select a source from sources but match no marker ids, so replace_source(-1, ...) keeps every original marker, attaches replacement rows under id -1, and overwrites the last source's metadata.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 21b32de. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
PanelSources.name,version, and the other single-source properties raise unless the panel has exactly one source.concatenatejoins panels. Equality ignores source order.Test plan
replace_source, andsource_as_paneltests passMade with Cursor